Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert instead of return when no function selectors match #639

Merged
merged 4 commits into from
Jan 28, 2022
Merged

Revert instead of return when no function selectors match #639

merged 4 commits into from
Jan 28, 2022

Conversation

sezna
Copy link
Contributor

@sezna sezna commented Jan 13, 2022

Closes #444

@sezna sezna added the compiler General compiler. Should eventually become more specific as the issue is triaged label Jan 13, 2022
@sezna sezna self-assigned this Jan 13, 2022
AlicanC
AlicanC previously approved these changes Jan 13, 2022
View reviewed changes
Copy link
Contributor

@AlicanC AlicanC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙌

adlerjohn
adlerjohn suggested changes Jan 13, 2022
View reviewed changes
Copy link
Contributor

@adlerjohn adlerjohn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI failing

@sezna sezna marked this pull request as draft January 14, 2022 00:54
@sezna sezna marked this pull request as ready for review January 28, 2022 16:30
@sezna sezna merged commit bba0d64 into master Jan 28, 2022
@sezna sezna deleted the sezna/444 branch January 28, 2022 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adlerjohn adlerjohn adlerjohn approved these changes

@otrho otrho Awaiting requested review from otrho

@canndrew canndrew Awaiting requested review from canndrew

@eureka-cpu eureka-cpu Awaiting requested review from eureka-cpu

@AlicanC AlicanC Awaiting requested review from AlicanC

Assignees

@sezna sezna

Labels
compiler General compiler. Should eventually become more specific as the issue is triaged
Projects
Fuel Network
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

A contract should revert when no fn selector matches
4 participants
@sezna @AlicanC @adlerjohn @eureka-cpu