-
Notifications
You must be signed in to change notification settings - Fork 5.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove direct dependency on curl
#651
Conversation
$ cargo tree --invert openssl-sys
openssl-sys v0.9.72
├── curl v0.4.42
│ └── isahc v0.9.14
│ └── http-client v6.5.1
│ └── surf v2.3.2
│ ├── cynic v0.14.1
│ │ └── fuel-gql-client v0.1.2
│ │ └── forc v0.2.1 (/home/devel/local/fuellabs/sway/forc)
│ │ └── test v0.2.1 (/home/devel/local/fuellabs/sway/test)
│ └── fuel-gql-client v0.1.2 (*)
└── curl-sys v0.4.52+curl-7.81.0
├── curl v0.4.42 (*)
└── isahc v0.9.14 (*) Filed follow-up issue: FuelLabs/fuel-core#133 |
e9c0f3b
to
fa7d80b
Compare
are we ok with having two http clients? one blocking (ureq) and the other non-blocking (reqwest) |
Prior to this PR, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Will wait for @sezna |
Fixes #567
rustls-tls
feature forreqwest
and turn off default features (which would use native OpenSSL).ureq
instead ofcurl
.