IR generation for storage accesses #959
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mohammadfawaz
added
enhancement
otrho
suggested changes
Mar 18, 2022
| *ptr.get_type(context), | ||
| &ast_reassignment.lhs[1..] | ||
| .iter() | ||
| .map(|x| x.name.clone()) |
There was a problem hiding this comment.
Man, I have refactored all the struct stuff in my current working branch... some of this is going to be a pain to merge. 😬
sway-core/Cargo.toml
Outdated
| generational-arena = "0.2" | ||
| bigint = "4.3.3" |
There was a problem hiding this comment.
Did you deliberately add these?
There was a problem hiding this comment.
Oups - I needed that for something else and I don't anymore. I'll take it out.
adlerjohn
reviewed
Mar 18, 2022
mohammadfawaz
force-pushed
the
mohammadfawaz/generate_ir_for_storage
branch
from
e806310
to
4a16e0e
Compare
otrho
approved these changes
Mar 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part 2 of the storage change.
This PR does two things;
Credit to @sezna for starting this work in #646. Many pieces of this code were borrowed from that PR.