-
Notifications
You must be signed in to change notification settings - Fork 5.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
IR generation for storage accesses #959
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you have any unit tests, especially .sw
-> .ir
?
*ptr.get_type(context), | ||
&ast_reassignment.lhs[1..] | ||
.iter() | ||
.map(|x| x.name.clone()) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Man, I have refactored all the struct stuff in my current working branch... some of this is going to be a pain to merge. 😬
sway-core/Cargo.toml
Outdated
generational-arena = "0.2" | ||
bigint = "4.3.3" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did you deliberately add these?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oups - I needed that for something else and I don't anymore. I'll take it out.
e806310
to
4a16e0e
Compare
Part 2 of the storage change.
This PR does two things;
Credit to @sezna for starting this work in #646. Many pieces of this code were borrowed from that PR.