Skip to content
This repository has been archived by the owner on Feb 23, 2024. It is now read-only.

feat: add dropdown to select token on swap #184

Merged
merged 9 commits into from May 23, 2022
Merged

Conversation

pedronauck
Copy link
Member

@pedronauck pedronauck commented May 21, 2022

Fix #174
Fix #131

Kapture 2022-05-20 at 21 02 46

@pedronauck pedronauck added the feature New features that need to be implemented label May 21, 2022
@pedronauck pedronauck self-assigned this May 21, 2022
@vercel
Copy link

vercel bot commented May 21, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
swayswap ✅ Ready (Inspect) Visit Preview May 23, 2022 at 8:39PM (UTC)

@pedronauck
Copy link
Member Author

got #131 fixed as well ✌️

Kapture 2022-05-20 at 21 10 45

} else {
activeInput.current = ActiveInput.to;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is causing the issue you see when inverting fields

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We use reference here because we need a nonstate delayed change.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Screen.Recording.2022-05-20.at.9.32.20.PM.mov

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding the startTransition

packages/app/src/pages/SwapPage/SwapComponent.tsx Outdated Show resolved Hide resolved
…-select

* 'master' of github.com:FuelLabs/swayswap:
  ci: add action for validate pull request (#178)
  feat: add user guided states on swap (#188)
  docs: add links for live previews (#183)
  feat(PoolPage): improve button feedback. reload/clear after create liquidity (#187)
  feat(PoolPage): When set input value, calculate the other input value. Validate if pool ratio is right (#185)
  feat: Save state of pool page (#164)
} else {
activeInput.current = ActiveInput.to;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding the startTransition

@pedronauck pedronauck merged commit 64d2428 into master May 23, 2022
@pedronauck pedronauck deleted the feat/token-select branch May 23, 2022 20:47
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature New features that need to be implemented
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enable token select dropdown on swap On swap when inverting values its showing insufficient liquidity
2 participants