This repository has been archived by the owner on Feb 23, 2024. It is now read-only.
fix: coin input value being cut by bottom line balance #286
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pedronauck
suggested changes
Jun 14, 2022
| ); | ||
|
|
||
| return ( | ||
| <div className="flex items-center justify-end gap-2 mt-2 whitespace-nowrap"> |
There was a problem hiding this comment.
Since you created a coin-balance.css you can move all these tailwind helper classes for a unique class using coinBalance in the root div component and maybe creating a coinBalance--balance class also
There was a problem hiding this comment.
I think it's better to remove coin-balance.css and keep everything inline, no needs to have separate file to hold 1 class. will do that
luizstacio
suggested changes
Jun 14, 2022
.gitignore
Outdated
| @@ -41,7 +41,8 @@ node_modules | |||
|
|
|||
| # testing | |||
| coverage | |||
| cypress | |||
| cypress/videos | |||
There was a problem hiding this comment.
cypress should cover both videos and screenshots
There was a problem hiding this comment.
yes but only cypress it's ignoring other cypress stuffs, like the e2e tests.
There was a problem hiding this comment.
You can use path specfic /cypress
luizstacio
previously approved these changes
Jun 14, 2022
pedronauck
approved these changes
Jun 14, 2022
luizstacio
approved these changes
Jun 14, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CoinBalancecomponent fromCoinSelectorto centralize balance behavior in a different line and fix the layout bug.Closes Coin input is getting cut when balance and typed value are too big #236