Skip to content
This repository has been archived by the owner on Feb 23, 2024. It is now read-only.

fix: correct behavior when typing only "." in the coin input #291

Merged
merged 1 commit into from Jun 15, 2022
Merged

fix: correct behavior when typing only "." in the coin input #291

merged 1 commit into from Jun 15, 2022

Conversation

LuizAsFight
Copy link
Contributor

  • addressed bug when typing only "." in the coin input
  • created unit test to make sure it's working on the way it's supposed to

Closes #287

@LuizAsFight LuizAsFight self-assigned this Jun 15, 2022
luizstacio
luizstacio approved these changes Jun 15, 2022
View reviewed changes
Copy link
Member

@luizstacio luizstacio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@LuizAsFight LuizAsFight merged commit 8f1234f into master Jun 15, 2022
@LuizAsFight LuizAsFight deleted the lf-287/fix/coininput-decimal branch June 15, 2022 05:21
pedronauck added a commit that referenced this pull request Jun 17, 2022
@pedronauck
Merge branch 'master' of github.com:FuelLabs/swayswap into refac/swap
58eb87b 
* 'master' of github.com:FuelLabs/swayswap:
  feat: move check branch to commit step (#292)
  feat: add agreement and update copy (#290)
  fix: correct behavior when typing only "." in the coin input (#291)
  fix: coin input value being cut by bottom line balance (#286)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@luizstacio luizstacio luizstacio approved these changes

@pedronauck pedronauck Awaiting requested review from pedronauck

Assignees

@LuizAsFight LuizAsFight

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Decimal on empty input issue
2 participants
@LuizAsFight @luizstacio