Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OBSOLETE: TF coils winding pack #3043

Draft
wants to merge 37 commits into
base: feature/new_magnet_module
Choose a base branch
from

Conversation

ivanmaione
Copy link
Contributor

Linked Issues

Closes #138

Description

Interface Changes

Checklist

I confirm that I have completed the following checks:

  • Tests run locally and pass pytest tests --reactor
  • Code quality checks run locally and pass pre-commit run --from-ref develop --to-ref HEAD
  • Documentation built locally and checked sphinx-build -W documentation/source documentation/build

@ivanmaione ivanmaione requested a review from a team as a code owner February 26, 2024 17:02
@CoronelBuendia CoronelBuendia changed the base branch from develop to feature/new_magnet_module February 27, 2024 07:59
@CoronelBuendia CoronelBuendia requested review from a team as code owners February 27, 2024 07:59
@je-cook je-cook marked this pull request as draft March 4, 2024 14:44
@je-cook
Copy link
Contributor

je-cook commented Mar 6, 2024

Just something I noticed in matplotlib while starting to have a play with this. When using ax.fill by default mpl will snap patches to the nearest pixel this created some weird artefacts in the figures of the winding pack in favour of being faster to render and plot.

To have a more accurate representation of the patch you can supply the snap kwarg to ax.fill like so:
ax.fill(...., snap=False)

It produces this for the TF example which while still having some artefacting is slightly better if being slightly slower to plot:
image

snap docs:
https://matplotlib.org/stable/api/_as_gen/matplotlib.artist.Artist.set_snap.html#matplotlib.artist.Artist.set_snap

@CoronelBuendia
Copy link
Contributor

Could we possibly get a rebase? I changed the target branch to the feature branch but that may have messed things up.. Will certainly make it easier for me to review!

@ivanmaione ivanmaione force-pushed the ivanmaione/TF_wp_from_magnet-fatigue branch from 15f0310 to 9626e54 Compare March 8, 2024 22:54
Copy link

sonarcloud bot commented Mar 8, 2024

Quality Gate Passed Quality Gate passed

Issues
132 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
2.3% Duplication on New Code

See analysis details on SonarCloud

@ivanmaione ivanmaione changed the title WIP: TF coils winding pack OBSOLETE: TF coils winding pack Mar 9, 2024
@je-cook je-cook force-pushed the feature/new_magnet_module branch 3 times, most recently from fb72b27 to d33aa03 Compare June 4, 2024 06:19
@je-cook je-cook force-pushed the feature/new_magnet_module branch 3 times, most recently from 3465d37 to df28ad1 Compare June 28, 2024 14:43
@je-cook je-cook force-pushed the feature/new_magnet_module branch 2 times, most recently from d589cd4 to 782c8f9 Compare July 9, 2024 08:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Winding pack design optimisations
3 participants