Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

English messages.properties inconsistencies #2251

Open
Aaron-Ritter opened this issue May 5, 2023 · 4 comments
Open

English messages.properties inconsistencies #2251

Aaron-Ritter opened this issue May 5, 2023 · 4 comments
Assignees
Labels

Comments

@Aaron-Ritter
Copy link
Collaborator

Aaron-Ritter commented May 5, 2023

Inconsistencies and possible issues found in messages.properties

There are a few inconsistencies and possible issues I found in messages.properties while working on the German translation.

Parent and Legal guardian messages

At the moment the messages are inconsistent, I think all of these lines should be updated to "your parent or legal guardian".

Line  27: child-registration-not-allowed=We cannot create an account for you. Your parent or guardian can create an account for you. Enter their email address and we will ask them to create your account.
Line  95: parent-notified=We've sent an email to your parent. They can set up an account for you once they receive it.
Line  96: parent-notified-title=Parent notified
Line 119: provide-parent-email=Provide parent email
Line 186: parentEmail=Parent's email

Return to login messages

There are two properties which have as a value "Return to Login" where back-to-login I couldn't find referenced in any of the templates only return-to-login is used. In addition there is one property link text return-to-normal-login containing "Return to the normal login" which isn't "Return to normal login" mentioned in webauthn-reauth-return-to-login.

Based on that I have two questions is "Return to normal login" in webauthn-reauth-return-to-login referencing return-to-normal-login and if so which one should be updated. In addition to that, if one message value contains another message property shouldn't the property be linked instead of hardcoded as it can cause inconsistencies?

Line  20: back-to-login=Return to Login
Line 130: return-to-login=Return to login
Line 131: return-to-normal-login=Return to the normal login
Line 157: webauthn-reauth-return-to-login=If you don't recognize the passkeys(s) above click "Return to normal login" below.

Non-alphanumeric character vs special character

In German it is more common to use special character than non-alphanumeric character, isn't that true for English?

Line  98: password-alpha-constraint=Must contain at least one non-alphanumeric character
Line 415: [onlyAlpha]password=Password requires a non-alphanumeric character

Public and shared device

To avoid user error (not reading the whole sentence) and enforce a securer user behavior it might be better to start with, in which case not to do something rather than the other way around.

Line 403: {tooltip}remember-device=Check this to stay signed into FusionAuth for the configured duration, do not select this on a public computer or when this device is shared with multiple users
Line 404: {tooltip}trustComputer=Check this to bypass two-factor authentication for the configured duration, do not select this on a public computer or when this device is shared with multiple users

Contact Support

It would make sense to standardize the message of contacting administrator or support.

Line 441: [inactive]user.email=An account already exists for that email but is locked. Contact the administrator for assistance
Line 460: [inactive]user.username=An account already exists for that username but is locked. Contact the administrator for assistance
Line 491: [EmailVerificationDisabled]=Email verification functionality is currently disabled. Contact your FusionAuth administrator for assistance.
Line 494: [ForgotPasswordDisabled]=Forgot password handling is not enabled. Please contact your system administrator for assistance.
Line 498: [InvalidIdentityProviderId]=Invalid request. Unable to handle the identity provider login. Please contact your system administrator or support for assistance.
Line 517: [OAuthv1TokenMismatch]=Invalid request. The token provided on the OAuth v1 callback did not match the one sent during authorization. Unable to handle the identity provider login. Please contact your system administrator or support for assistance.
Line 533: [UserExpiredException]=Your account has expired. Please contact your system administrator.
Line 534: [UserLockedException]=Your account has been locked. Please contact your system administrator.
Line 602: [SelfServiceFormNotConfigured]=Configuration is incomplete. The FusionAuth administrator must configure a form for this application.

SMS 2FA Message

Phone number formats depend heavily on the country, especially with services where you have users from multiple countries you wont get the format right and therefore we would suggest to rephrase it excluding the number format all together.

Line 255: two-factor-get-code-at-sms=Get a code at (***) ***-**%s

Grammatical errors

There are a few Grammatical errors to correct.

Line 278: sms-enable-step-1=Two enable two-factor using SMS, enter a mobile phone and click the button to send a one-time use code. Once you receive the code, enter it in the form below.
Line 279: oauth2-sms-enable-step-1=Two enable two-factor using SMS, enter a mobile phone and click the button to send a one-time use code. Once you receive the code, enter it in the form below.
Line 565: [ExternalAuthenticationException]SAMLIdPInitiatedResponseSolicited=The SAML AuthNResponse contained an InResponseTo attribute. In an IdP Initiated Login this is un-expected.
Line 351: # - The first section label on the User and and Registration form in the admin UI will be omitted unless
@robotdan
Copy link
Member

robotdan commented May 8, 2023

All localized versions are managed via https://github.com/FusionAuth/fusionauth-localization. If there are issues with any of them, please open a PR against that repo for a correction.

@mooreds
Copy link
Collaborator

mooreds commented May 8, 2023

FYI @robotdan

@Aaron-Ritter and team are doing some work on that repo, but we're tracking all of the Sonderformat work via issues here so they have one place to look.

That's what this issue is all about.

@mooreds
Copy link
Collaborator

mooreds commented May 8, 2023

Will start labeling these types of issues with devrel so you can ignore.

@Aaron-Ritter
Copy link
Collaborator Author

@mooreds this issue has all the related pull requests created and is ready for review. With the exception of "Public and shared device" which is a very minor detail we found and we are not sure if it needs changing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants