Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gad 2 added notifications and tracking for each file. #1553

Merged
merged 2 commits into from
Apr 25, 2024

Conversation

Srivatsa19
Copy link

Issue that this pull request solves

Added notifications and tracking for each file.
Closes: # (issue number)

Proposed changes

Brief description of what is fixed or changed

Types of changes

Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Other (please describe):

Checklist

Put an x in the boxes that apply

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have created new branch for this pull request
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • My changes does not break the current system and it passes all the current test cases.

Screenshots

Please attach the screenshots of the changes made in case of change in user interface

Other information

Any other information that is important to this pull request

@Priyansh61
Copy link

@Srivatsa19 is the iwdmodulev2 different from the existing iwdmodule?

@Srivatsa19
Copy link
Author

@Srivatsa19 is the iwdmodulev2 different from the existing iwdmodule?

The use case diagram was updated so we had to change the implementation.

@Priyansh61
Copy link

Lgtm!!

@Priyansh61
Copy link

@prabhatsuman @anudeeps0306 guys can you please merge this to latest_staging?

@Priyansh61 Priyansh61 merged commit 40dd12e into FusionIIIT:gad-2 Apr 25, 2024
@prabhatsuman
Copy link

prabhatsuman commented Apr 27, 2024

@Priyansh61 @itsspriyansh there are errors in notification after merge of Gad-2 into latest_staging
IMG-20240427-WA0010
l

@prabhatsuman
Copy link

@Srivatsa19 please see the error and correct it ASAP!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants