Wiser, safer vendor includes #78
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We discussed offline over slack. Please move the css tree to Rest LGTM. |
kratiahuja
reviewed
May 19, 2017
index.js
Outdated
| content => `if (typeof FastBoot === 'undefined') { ${content} }` | ||
| ); | ||
|
|
||
| return new MergeTrees(vendorTree, dropzoneJs); |
There was a problem hiding this comment.
new MergeTrees([vendorTree, dropzoneJs]);
index.js
Outdated
| } | ||
| ); | ||
|
|
||
| return new MergeTrees(styleTree, dropzoneCss); |
There was a problem hiding this comment.
Seems trying to merge with a null tree throws an error Expected Broccoli node, got undefined for inputNodes[0]
|
Hey, this looks good. Could you rebase with the latest changes on the dev branch? Thanks! |
|
Had to rebase with newer changes. Added these changes to most recent commit d9355e3 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #76- @kratiahuja, maybe you could give your 2 cents?