Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Split WebXR and WebVR #5064

Merged
merged 1 commit into from
Sep 3, 2019
Merged

feat: Split WebXR and WebVR #5064

merged 1 commit into from
Sep 3, 2019

Conversation

ExE-Boss
Copy link
Contributor

@ExE-Boss ExE-Boss commented Sep 1, 2019

Chrome 79 has removed support for WebVR.

Without this, it’s impossible to display this in the “Can I use…” data.


Reverts: #4456
See also: #3948

/cc @jpmedley

@Fyrd
Copy link
Owner

Fyrd commented Sep 3, 2019

Yeah, seems like the right thing to do. Thanks!

@Fyrd
Copy link
Owner

Fyrd commented Sep 3, 2019

Looks like XR data needs some updating... the numbered notes should probably be removed and I'm not seeing support in Chrome 76.

Copy link
Contributor

@jpmedley jpmedley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry I was out. There are things in here that should be corrected.

"76":"y",
"77":"y",
"78":"y",
"79":"y"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Anything before 79 should be "n". The same would apply for Android Chrome and Android WebView. (I don't know how you do those.)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It says 'origin trial'. That means that individual sites would require a token to activate the API. Origin trial tokens will be unavailable when the API ships in 79.

@@ -0,0 +1,368 @@
{
"title":"WebXR Device API",
"description":"API for accessing virtual reality (VR) and augmented reality (AR) devices, including sensors and head-mounted displays.",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This definition ignores AR use cases which have applications outside of games. The spec was designed specifically (so it's author tells me) to address a spectrum of immersion so that a site could use as little or as much immersion as it wanted. See my article for more on that.

],
"bugs":[
{
"description":"WebXR is in development and is still changing. WebXR was formally developed as WebVR. Because of this there could be bugs inside the standard of the W3C."
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

WebXR was formally developed as WebVR.

There's some historical truth to this. The spec has evolved so much in more than two years that I'm not sure it's relevant to users of the API. Neither Google nor MDN feel the need to mention this in WebXR documentation.

Because of this there could be bugs inside the standard of the W3C.

What does this mean?

"2.5":"n"
}
},
"notes":"For a WebXR experience a head mounted display (VR HMD) is required.",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not true. Look at XR.requestSession() and XR.supportsSession(). The API supports a session mode called "inline" with which content can be rendered in a page.

@ExE-Boss
Copy link
Contributor Author

ExE-Boss commented Sep 3, 2019

@jpmedley To all your questions:

I just copied the webvr.json file from #4456, before I reverted that PR, so take it up with @Utopiah

@Fyrd
Copy link
Owner

Fyrd commented Sep 4, 2019

I've updated the feature data with help from @jpmedley's comments and made the feature available on the site now. For any further suggested changes please submit a new PR. Thanks all!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants