Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add partial support for AVIF in Edge Dev/Canary #6756

Merged
merged 4 commits into from
Jun 28, 2023
Merged

Conversation

Th3S4mur41
Copy link
Contributor

It doesn't work in Edge 116 (Dev/Canary) on Windows 10 21H2.
It works in Edge 116 (Dev/Canary) on Windows 11 Moment 3 (22621.1848).

To be confirmed if Moment 3 is the key factor here?
It doesn't work in Edge 114 (Stable) on Windows 11 Moment 3 (22621.1848).

Need some help with the validation here too, since Edge Canary is not part of the data model yet.

After setting all flags and requirements, avif doesn't seem to work on Windows 10.
So far it looks like Windows 11 Moment 3 might be the requirement. Needs further verification though
@Th3S4mur41
Copy link
Contributor Author

@Fyrd could you help add the Missing Edge Beta/Canary versions to the data model?

@Fyrd
Copy link
Owner

Fyrd commented Jun 23, 2023

Support in Beta/Canary versions can be more in flux so any support data there is not as reliable as that for stable versions. As a result I'm only tracking stable Edge as most of the time support matches Chrome anyway.

Would recommend instead to add the information under "Notes" instead, especially if there's uncertainly on the subject.

@Th3S4mur41
Copy link
Contributor Author

Thanks @Fyrd PR updated as suggested

@Fyrd
Copy link
Owner

Fyrd commented Jun 28, 2023

Thanks!

@Fyrd Fyrd merged commit ee0f131 into Fyrd:main Jun 28, 2023
1 check passed
@tats-u
Copy link
Contributor

tats-u commented Aug 25, 2023

@Th3S4mur41 The note you added misleads us into believing that Edge 116 Stable had been going to add support for AVIF. You never heard that Edge Stable would add support for AVIF, did you? We have to modify the misleading note.

@Th3S4mur41
Copy link
Contributor Author

Th3S4mur41 commented Aug 25, 2023

@tats-u you are right, avif support was enabled by default to Edge 116 in the canary channel, but it has not been ported to the stable channel yet.

So, all they did with 116 was remove the necessity to add the --enable-features=msEdgeAVIF argument to the msedge.exe shortcut.

One other requirement that I'm currently verifying, is that it looks like avif support also requires to be on one of the Windows Insider channels.

There is a Draft PR ready as soon as the Windows part of the note is confirmed

Th3S4mur41 added a commit to Th3S4mur41/caniuse that referenced this pull request Aug 25, 2023
@tats-u
Copy link
Contributor

tats-u commented Aug 25, 2023

@Th3S4mur41

avif support was enabled by default to Edge 116 in the canary channel,

No, since 114. The flag has been activated since 112 but the display feature was lacked at that time.
I have been watching the AVIF feature in Edge Insider (& stable) since then.

Fyrd pushed a commit that referenced this pull request Sep 5, 2023
* Update note about Edge avif support

#6756 (comment)

* remove avif support generic note

The proven support is already covered with note #6
Support without the flag in Edge 116 and 117 seems to be spotty and cannot be reproduced reliably
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants