Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filter empty datacite (ORC)ID fields #77

Closed
mpsonntag opened this issue Dec 5, 2020 · 4 comments · Fixed by #90
Closed

Filter empty datacite (ORC)ID fields #77

mpsonntag opened this issue Dec 5, 2020 · 4 comments · Fixed by #90
Assignees

Comments

@mpsonntag
Copy link
Contributor

The xml has empty ORCID fields because in the datacite the IDs are missing. Could that be filtered?

@mpsonntag
Copy link
Contributor Author

mpsonntag commented Dec 5, 2020

As an example for the problem that occurred in DOI 6weafc:

A YAML entry

authors:
  - ...
    id: "ORCID:"

results in an XML entry

<nameIdentifier schemeURI="" nameIdentifierScheme="">ORCID:</nameIdentifier>

@achilleas-k
Copy link
Member

achilleas-k commented Dec 5, 2020

The offending function/line is in libgin: https://github.com/G-Node/libgin/blob/7cddc5bb2c86ea49da5bec0df4a3a40f4896d40e/libgin/datacite.go#L191

The fallback result of the parse ID function, if it can't identify the type of ID or the ID doesn't match a known format, is to just return whatever the author provided with empty URI and scheme.

@mpsonntag
Copy link
Contributor Author

IDs that provide a supported ID prefix (orcid and researcherid) but do not have a value, should not create an XML entry, a warning to the admin should be issued.

@mpsonntag mpsonntag self-assigned this Mar 18, 2021
@mpsonntag
Copy link
Contributor Author

Issue requires changes in G-Node/libgin.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants