-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Additional admin warnings #90
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes G-Node#73 Reference types other than 'IsSupplementTo' now elicit a warning.
Pull Request Test Coverage Report for Build 698787967
💛 - Coveralls |
... to mirror the datacite.yaml data structure.
Closes G-Node#94 Reformats message display when datacite.yaml is invalid or has missing required entries. - messages are now displayed as a list on the requfail page - duplicate entries are removed
Add warning if the datacite resourceType is not 'Dataset'.
Do not create an authorID link if no valid SchemeURI has been identified.
achilleas-k
approved these changes
Apr 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds additional admin warnings when processing a DOI request. Some of these changes require changes in the libgin library merged into master.
isSupplementTo
is used. Closes Allow all reftypes through the validator #73.resourceType
is notDataset
.identified to avoid in-site broken links.
datacite.yaml
file or when unsupported datacite values have been used, the collected error messages are now shown to the user as a formatted list. Closes Itemize invalid DOI request messages #94.The PR also updates the README file and adds CI badges and links.