Minor changes in datacite handling #29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When encountering an authorID that is clearly missing its value e.g. 'orcid:' or 'researcherid:', parseAuthorID now returns nil instead of an authorID with URI and scheme but no value.
References are no longer added to Datacite via the AddReference func if either the reference ID or type cannot be identified or are not provided.
Pull Request Test Coverage Report for Build 667825932
💛 - Coveralls |
Closes G-Node#30 Separators are now succeeded by spaces.
Adds docstrings to all functions, methods and structs. Adds projects references of used and deprecation notices of unused functions, methods and structs.
achilleas-k
approved these changes
Mar 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces minor changes to handling of Datacite.AuthorID and Datacite.Reference:
parseAuthorIDfunction now returnsnilinstead of an AuthorID with URI and scheme but no value. Required for gin-doi issue #77.AddReferencefunction if either the referenceIDortypecannot be identified or are not provided. Required for gin-doi issue #76.RenderAuthorhandling; separators (, and ;) are now succeeded by a string. Closes Introduce spaces to RenderAuthor() #30.util.goare added.doi.goare added.doi.go.