nix-tool only for shared library build #754
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gicmo
reviewed
Oct 16, 2018
|
|
||
| #pkg-config support | ||
| configure_file(${CMAKE_SOURCE_DIR}/nix.pc.in ${CMAKE_BINARY_DIR}/nix.pc) | ||
| install(FILES ${CMAKE_BINARY_DIR}/nix.pc DESTINATION ${LIB_INSTALL_DIR}/pkgconfig) | ||
|
|
||
| if(NOT EXISTS "${LIB_INSTALL_DIR}/pkgconfig/nix.pc") |
There was a problem hiding this comment.
hmm, if we wanna package libnixio (debian, fedora) and ship the static and non-static version, then this might now work, because you build in a build-root that is separate from there rest of the system.
Maybe better would be a config option?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this pr is part of the nix-mx, brew installation problem solution. This pr:
We should be able to install static and shared lib in parallel without brew complaining about overwriting links 🤞