Catch out of bounds indexing errors in datasets #303
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Catches out-of-bounds indexing before calling read_direct() in h5py to make the error message and exception type clearer.
Check that out of bounds indexing for data raises IndexError (instead of the h5py TypeError).
achilleas-k
added a commit
to achilleas-k/nixpy
that referenced
this pull request
Jul 11, 2018
H5Py throws ValueError for out-of-bounds indexing. We catch it and throw IndexError instead, reusing the error message from H5Py. This also makes indexing more flexible. Slices now work the same as in numpy, so no slice is ever out-of-bounds. The corresponding test has been updated accordingly. This is an updated version of PR G-Node#303, which was a fix for G-Node#299.
achilleas-k
added a commit
to achilleas-k/nixpy
that referenced
this pull request
Jul 12, 2018
H5Py throws ValueError for out-of-bounds indexing. We catch it and throw IndexError instead, reusing the error message from H5Py. This also makes indexing more flexible. Slices now work the same as in numpy, so no slice is ever out-of-bounds. The corresponding test has been updated accordingly. This is an updated version of PR G-Node#303, which was a fix for G-Node#299.
achilleas-k
added a commit
to achilleas-k/nixpy
that referenced
this pull request
Jul 12, 2018
H5Py throws ValueError for out-of-bounds indexing. We catch it and throw IndexError instead, reusing the error message from H5Py. This also makes indexing more flexible. Slices now work the same as in numpy, so no slice is ever out-of-bounds. The corresponding test has been updated accordingly. This is an updated version of PR G-Node#303, which was a fix for G-Node#299.
achilleas-k
added a commit
to achilleas-k/nixpy
that referenced
this pull request
Jul 12, 2018
H5Py throws ValueError for out-of-bounds indexing. We catch it and throw IndexError instead, reusing the error message from H5Py. This also makes indexing more flexible. Slices now work the same as in numpy, so no slice is ever out-of-bounds. The corresponding test has been updated accordingly. This is an updated version of PR G-Node#303, which was a fix for G-Node#299.
achilleas-k
added a commit
to achilleas-k/nixpy
that referenced
this pull request
Jul 12, 2018
H5Py throws ValueError for out-of-bounds indexing. We catch it and throw IndexError instead, reusing the error message from H5Py. This also makes indexing more flexible. Slices now work the same as in numpy, so no slice is ever out-of-bounds. The corresponding test has been updated accordingly. This is an updated version of PR G-Node#303, which was a fix for G-Node#299.
achilleas-k
added a commit
to achilleas-k/nixpy
that referenced
this pull request
Jan 18, 2019
H5Py throws ValueError for out-of-bounds indexing. We catch it and throw IndexError instead, reusing the error message from H5Py. This also makes indexing more flexible. Slices now work the same as in numpy, so no slice is ever out-of-bounds. The corresponding test has been updated accordingly. This is an updated version of PR G-Node#303, which was a fix for G-Node#299.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DataSet.__getitem__checks if the indexes or slices are out of bounds before calling theread_data()methods, in order to throw a more useful error message.Fixes #299.