Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dataframe compatibility test #355

Merged
merged 8 commits into from
Dec 13, 2018
Merged

Dataframe compatibility test #355

merged 8 commits into from
Dec 13, 2018

Conversation

hkchekc
Copy link
Member

@hkchekc hkchekc commented Dec 10, 2018

I add the basic ones for DFs in the test_full_file and test_full_file_read functions.

So, basic write and read compatibilities are checked.

Please suggest any further test needed.

@coveralls
Copy link

Coverage Status

Coverage increased (+1.1%) to 88.457% when pulling 6de170b on hkchekc:df_compat into f8bf986 on G-Node:no-bindings-dev.

@coveralls
Copy link

coveralls commented Dec 10, 2018 •
edited
Loading

Coverage Status

Coverage decreased (-0.2%) to 89.688% when pulling cb1cb9c on hkchekc:df_compat into 864cbc3 on G-Node:no-bindings-dev.

achilleas-k
achilleas-k approved these changes Dec 13, 2018
View reviewed changes
Copy link
Member

@achilleas-k achilleas-k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@achilleas-k achilleas-k merged commit b2064da into G-Node:no-bindings-dev Dec 13, 2018
@hkchekc hkchekc deleted the df_compat branch December 13, 2018 19:44
@achilleas-k achilleas-k mentioned this pull request May 7, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@achilleas-k achilleas-k achilleas-k approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@hkchekc @coveralls @achilleas-k