Lock: Add missing null check #66
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This resulted in a NullReferenceException hiding the expected LockNotHeldException G-Research#65
|
@georgy93 mentions
|
|
|
||
| var distributedLock = _client.CreateLock(new LockOptions(keyName) | ||
| { | ||
| SessionTTL = TimeSpan.FromSeconds(DefaultSessionTTLSeconds), |
There was a problem hiding this comment.
I don't think that defining these values as constants improves the test readability, but I'm not against it either.
There was a problem hiding this comment.
Fine by me either way. #67 uses them too
|
Hi @georgy93, could you please review this PR and confirm this is your actual use case? |
marcin-krystianc
approved these changes
Feb 11, 2021
|
Let's merge this? @marcin-krystianc @jgiannuzzi |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes part of #65 (should be split in 2 issues).
This resulted in a NullReferenceException hiding the expected (?) LockNotHeldException.