Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Integration test coverage increase #436

Merged
merged 15 commits into from
Oct 20, 2023
Merged

Integration test coverage increase #436

merged 15 commits into from
Oct 20, 2023

Conversation

fabiovincenzi
Copy link
Collaborator

fixes #331

@fabiovincenzi fabiovincenzi linked an issue Oct 11, 2023 that may be closed by this pull request
AIM refactor phase 1: finish incomplete integration tests #331
Closed
@jgiannuzzi jgiannuzzi deleted the branch G-Research:main October 16, 2023 21:37
@jgiannuzzi jgiannuzzi closed this Oct 16, 2023
@fabiovincenzi fabiovincenzi reopened this Oct 17, 2023
@fabiovincenzi fabiovincenzi changed the base branch from features/namespaces to main October 17, 2023 06:52
@fabiovincenzi fabiovincenzi reopened this Oct 18, 2023
fabiovincenzi and others added 13 commits October 18, 2023 09:53
@fabiovincenzi
Update app with incorrect ID integration test
bb9b835
@fabiovincenzi
requestBody type
53702fd
@fabiovincenzi
add UpdateDashboard with incorrect ID
acd7cc8
@fabiovincenzi
add Update Run with incorrect ID
abd11da
@fabiovincenzi
incorrect id experiment delete
0165733
@fabiovincenzi
incorrect experiment id in experiment activity
5d10fcb
@dsuhinin @fabiovincenzi
code normalising according to linter remarks (G-Research#420)
94039ac 
What's done:
- fixed all the `linter` remarks.
- integrate `golangci-lint` into build pipeline.
- remove `staticcheck` and `vet` from build pipline.
@dsuhinin @fabiovincenzi
Redesign HTTP client for integration tests (G-Research#395)
ac58a03 
What's done:
- implemented new HTTP client for `integration` tests.
- all the `integration` tests now use new HTTP client implementation.
@fabiovincenzi
merge features/namespaces
67d87d3
@fabiovincenzi
fix lint problem
7a2e5b8
@fabiovincenzi
fix lint problem
dd7b501
@fabiovincenzi
mergin error
d72e1bb
@fabiovincenzi
fix merging errors
0a3d603
@fabiovincenzi fabiovincenzi force-pushed the integration-test-coverage-increase branch from 018563c to 0a3d603 Compare October 18, 2023 11:43
@fabiovincenzi fabiovincenzi requested review from jgiannuzzi, dsuhinin and suprjinx and removed request for jgiannuzzi and dsuhinin October 18, 2023 12:59
suprjinx
suprjinx approved these changes Oct 18, 2023
View reviewed changes
Copy link
Contributor

@suprjinx suprjinx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fabiovincenzi fabiovincenzi merged commit 8a0c770 into G-Research:main Oct 20, 2023
18 checks passed
suprjinx pushed a commit to suprjinx/fasttrackml that referenced this pull request Oct 23, 2023
@fabiovincenzi @suprjinx
Integration test coverage increase (G-Research#436)
48233c8 
Increase aim integration test coverage
suprjinx pushed a commit to suprjinx/fasttrackml that referenced this pull request Oct 26, 2023
@fabiovincenzi @suprjinx
Integration test coverage increase (G-Research#436)
75ca838 
Increase aim integration test coverage
@fabiovincenzi fabiovincenzi deleted the integration-test-coverage-increase branch November 2, 2023 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@suprjinx suprjinx suprjinx approved these changes

@jgiannuzzi jgiannuzzi Awaiting requested review from jgiannuzzi

@dsuhinin dsuhinin Awaiting requested review from dsuhinin

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AIM refactor phase 1: finish incomplete integration tests
4 participants
@fabiovincenzi @suprjinx @jgiannuzzi @dsuhinin