Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prefer bars in single-case DU #26

Merged
merged 1 commit into from
Apr 30, 2021
Merged

Prefer bars in single-case DU #26

merged 1 commit into from
Apr 30, 2021

Conversation

Smaug123
Copy link
Contributor

Fixes #25.

(It's just more consistent this way.)

TobyShaw
TobyShaw approved these changes Apr 16, 2021
View reviewed changes
Copy link

@TobyShaw TobyShaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it worth mentioning that while F# allows you to omit the pipe, as of F# 5.0 it requires the pipe for any attributes to be attached to the constructor?

@nojaf nojaf mentioned this pull request Apr 30, 2021
Closed
3 tasks
@Smaug123
Copy link
Contributor Author

Interesting point - I think there's no real need to mention that though, since it's either a bug in the compiler or it's intended. Not in the purview of a style guide.

@Smaug123 Smaug123 merged commit 86e201d into master Apr 30, 2021
@Smaug123 Smaug123 deleted the du-bar branch April 30, 2021 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TobyShaw TobyShaw TobyShaw approved these changes

@jgiannuzzi jgiannuzzi jgiannuzzi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Presence of bar in union case.
3 participants
@Smaug123 @TobyShaw @jgiannuzzi