Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Idempotency problem related to comments in with #1686

Closed
3 tasks
Smaug123 opened this issue Apr 28, 2021 · 1 comment · Fixed by #1689
Closed
3 tasks

Idempotency problem related to comments in with #1686

Smaug123 opened this issue Apr 28, 2021 · 1 comment · Fixed by #1689

Comments

@Smaug123
Copy link
Contributor

Issue created from fantomas-online

Formatted code

namespace Foo

module Foo =
    let a =
        try
            failwith ""
        with
        // hi!
        :? Exception as e -> failwith ""

Reformatted code

namespace Foo

module Foo =
    let a =
        try
            failwith ""
        with
            // hi!
            :? Exception as e -> failwith ""

Problem description

Fantomas was not able to produce the same code after reformatting the result.

This looks like being #1647 again, maybe?
I still think the right answer here is to retain the | character, though.

Extra information

  • The formatted result breaks by code.
  • The formatted result gives compiler warnings.
  • I or my company would be willing to help fix this.

Options

Fantomas 4.4.0

    { config with
                SpaceBeforeColon = true
                SpaceBeforeSemicolon = true
                IndentOnTryWith = true }

Did you know that you can ignore files when formatting from fantomas-tool or the FAKE targets by using a .fantomasignore file?

@nojaf
Copy link
Contributor

nojaf commented Apr 30, 2021

This looks indeed like #1647 but with as e as a slight deviation.

I still think the right answer here is to retain the | character, though.

Yeah, working on that part from a style guide point of view first.

I'll create a follow-up issue to tackle the style change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants