Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix pip license error + add pip install command to readme #1419

Merged
merged 2 commits into from
Aug 31, 2021
Merged

Fix pip license error + add pip install command to readme #1419

merged 2 commits into from
Aug 31, 2021

Conversation

janosh
Copy link
Contributor

@janosh janosh commented Aug 28, 2021

As a follow-up to #1417, this should fix the pip license error and inform users through the readme that GAM can now be installed with pip.

Closes #720.

@taers232c
Copy link
Contributor

taers232c commented Aug 28, 2021

I got this: warning: the 'license_file' option is deprecated, use 'license_files' instead

I think you want:
license_files = ('LICENSE',)

@jay0lee
Copy link
Member

jay0lee commented Aug 28, 2021 via email

@taers232c
Copy link
Contributor

Where do the discovery document .json files reside?
Where does GamCommands.txt reside?

@janosh
Copy link
Contributor Author

janosh commented Aug 28, 2021

Let's hold off on the readme changes until this is stable and (maybe) on

@jay0lee Sure.

I got this: warning: the 'license_file' option is deprecated, use 'license_files' instead

Interesting. This deprecation is somewhat recent but I'm still surprised I've never seen this warning before.

@jay0lee jay0lee merged commit 108990c into GAM-team:main Aug 31, 2021
@janosh
Copy link
Contributor Author

janosh commented Oct 27, 2021

@jay0lee What's your current take on releasing to PyPI?

@janosh janosh mentioned this pull request Jan 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make GAM pip installable
3 participants