Make GAM pip-installable #1417
Make GAM pip-installable #1417
Conversation
src/setup.cfg
Outdated
| @@ -0,0 +1,48 @@ | |||
| [metadata] | |||
| name = Google Apps Manager | |||
There was a problem hiding this comment.
"GAM" no longer stands for anything (and Google has renamed the product twice since it did anyway). Make this:
GAM for Google Workspace
src/setup.cfg
Outdated
|
|
||
| [options] | ||
| packages = find: | ||
| python_requires = >=3.7 |
There was a problem hiding this comment.
3.6 is still supported today though that's going away soon enough
|
added a few comments but generally looks good to me. If you can hit those changes then we can merge this and see what pip will do when pointed at the GitHub repository. |
|
@jay0lee The thing I was uncertain about is will Also, how would the auth process work after pip-installation? Does it trigger automatically first time you try to invoke |
|
It seems to work with a command like: pip install git+https://github.com/jay0lee/GAM.git#subdirectory=src somethings wrong with the entry point though, I've made some changes to gam/main.py that should help. Also, the import restrictions from requirements.txt (only require distro if we're on Linux and only require importlib.metadata if we are Python < 3.8) needed to be added to setup.cfg for me. See my latest commit. |
|
Running pip install git+https://github.com/jay0lee/GAM.git#subdirectory=srcI get This is on macOS with Python 3.9.6. You didn't see this error? Also, should we add the install command to the readme? |
|
No, but I suspect if you remove src/ from the license line in setup.cfg it
will solve it.
Does pip really use .rtf format? The LICENSE file might be a battery choice
there for plaintext.
…On Fri, Aug 27, 2021, 3:11 PM Janosh Riebesell ***@***.***> wrote:
Running
pip install git+https://github.com/jay0lee/GAM.git#subdirectory=src
I get
creating GAM_for_Google_Workspace.egg-info
writing GAM_for_Google_Workspace.egg-info/PKG-INFO
writing dependency_links to GAM_for_Google_Workspace.egg-info/dependency_links.txt
writing entry points to GAM_for_Google_Workspace.egg-info/entry_points.txt
writing requirements to GAM_for_Google_Workspace.egg-info/requires.txt
writing top-level names to GAM_for_Google_Workspace.egg-info/top_level.txt
writing manifest file 'GAM_for_Google_Workspace.egg-info/SOURCES.txt'
reading manifest file 'GAM_for_Google_Workspace.egg-info/SOURCES.txt'
writing manifest file 'GAM_for_Google_Workspace.egg-info/SOURCES.txt'
Copying GAM_for_Google_Workspace.egg-info to build/bdist.macosx-11-x86_64/wheel/GAM_for_Google_Workspace-6.0.7-py3.9.egg-info
running install_scripts
error: [Errno 2] No such file or directory: 'src/license.rtf'
----------------------------------------
ERROR: Failed building wheel for GAM-for-Google-Workspace
This is on macOS with Python 3.9.6. You didn't see this error?
Also, should we add the install command to the readme?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#1417 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABDIZMDK4V4TXYIRKLANCJTT67PNTANCNFSM5C265YOQ>
.
|
Yes, I was going to submit a PR for that but awaiting your response on whether to mention pip install in readme.
Not sure. Support in what sense? It doesn't actually display it anyway, does it? Are you planning to release GAM on PyPI? |
This is just a rough draft to get the ball rolling on making GAM
pip-installable and closing #720. I hope to get some feedback since GAM has a slightly unusual package structure and I'm unfamiliar with GAMs current installation procedure.