Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🛠️ Re-enable no-unused-modules eslint rule #7453

Closed
4 tasks
esizer opened this issue Jul 31, 2023 · 4 comments · Fixed by #10741
Closed
4 tasks

🛠️ Re-enable no-unused-modules eslint rule #7453

esizer opened this issue Jul 31, 2023 · 4 comments · Fixed by #10741
Assignees
@yonikid15
Labels
tooling Tooling, automation and CI to support development.

Comments

@esizer
Copy link
Member

esizer commented Jul 31, 2023 •
edited
Loading

🛠️ Tooling

The eslint rule for no-unused-modules has been disabled since it was causing eslint to no longer work in VSCode.

🕵️ Details

It seems as though this specific rule does not work with non-standard config names, we need to figure out how to work around this issue.

🙋‍♀️ Proposed Solution

The rule is too slow to run effectively in local environments. Run it only on CI.

  • Wait until the library fixes the issue?
  • Define specific config for each package with this rule

Maybe look into combining configs? 🤔

✅ Acceptance Criteria

A set of assumptions which, when tested, verify that the debt tooling was properly updated and remains functional.

  • eslint still functions in CLI and IDE
  • eslint is checking for unused modules
  • performance is not affected
  • no-unused-modules rule runs in CI but not locally
@esizer esizer added the tooling Tooling, automation and CI to support development. label Jul 31, 2023
@tristan-orourke
Copy link
Member

@esizer is this still an issue?

@esizer
Copy link
Member Author

esizer commented Mar 13, 2024

@esizer is this still an issue?

Yeah, I was actually meaning to come back to some of these linting issues now that we have fixed the lint config.

@petertgiles
Copy link
Contributor

Problem is due to issues within the eslint library itself. Unsure if this has been fixed yet.

@tristan-orourke
Copy link
Member

If its slows down local eslint servers because linting runs all the time locally, can we run it in CI but not locally?

@yonikid15 yonikid15 self-assigned this Jun 18, 2024
@yonikid15 yonikid15 mentioned this issue Jun 20, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@yonikid15 yonikid15

Labels
tooling Tooling, automation and CI to support development.
Projects
GC Digital Talent
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Tooling] Add no-unused-modules rule to eslint GCTC-NTGC/gc-digital-talent
4 participants
@esizer @tristan-orourke @petertgiles @yonikid15