Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Tooling] Add no-unused-modules rule to eslint #10741

Merged
merged 13 commits into from
Jun 28, 2024

Conversation

yonikid15
Copy link
Contributor

🤖 Resolves #7453

👋 Introduction

🧪 Testing

  1. Run pnpm run lint
  2. Ensure rule isn't applied locally

@yonikid15 yonikid15 marked this pull request as ready for review June 26, 2024 16:19
@codecov-commenter
Copy link

codecov-commenter commented Jun 26, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 40.00000% with 24 lines in your changes missing coverage. Please review.

Project coverage is 38.53%. Comparing base (90b330b) to head (dff806e).

Files Patch % Lines
apps/web/src/utils/educationUtils.tsx 20.00% 4 Missing ⚠️
...eb/src/components/Instructions/InstructionList.tsx 0.00% 2 Missing ⚠️
...eb/src/components/Instructions/InstructionStep.tsx 0.00% 2 Missing ⚠️
apps/web/src/components/Instructions/index.ts 0.00% 2 Missing ⚠️
.../AnnouncementsPage/SitewideAnnouncementSection.tsx 0.00% 2 Missing ⚠️
...components/NotificationList/NotificationPortal.tsx 0.00% 1 Missing ⚠️
.../ApplicationInformation/ApplicationInformation.tsx 0.00% 1 Missing ⚠️
...CandidatePage/components/MoreActions/NotesForm.tsx 0.00% 1 Missing ⚠️
...cruitmentPage/CareerTimelineAndRecruitmentPage.tsx 0.00% 1 Missing ⚠️
...ntPage/components/CareerTimelineAndRecruitment.tsx 0.00% 1 Missing ⚠️
... and 7 more
Additional details and impacted files
@@             Coverage Diff              @@
##               main   #10741      +/-   ##
============================================
+ Coverage     38.26%   38.53%   +0.26%     
  Complexity     1652     1652              
============================================
  Files          1021     1012       -9     
  Lines         31207    30811     -396     
  Branches       6522     6422     -100     
============================================
- Hits          11942    11872      -70     
+ Misses        19100    18903     -197     
+ Partials        165       36     -129     
Flag Coverage Δ
integrationtests 67.89% <ø> (+0.09%) ⬆️
unittests 31.35% <40.00%> (+0.19%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@petertgiles petertgiles self-requested a review June 28, 2024 12:48
Copy link
Contributor

@petertgiles petertgiles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, a lot of dead code hacked out. 👏
I left a few style comments but nothing blocking.

apps/web/.eslintrc.cjs Outdated Show resolved Hide resolved
packages/ui/src/components/Accordion/types.ts Outdated Show resolved Hide resolved
@yonikid15 yonikid15 added this pull request to the merge queue Jun 28, 2024
Merged via the queue into main with commit 310e330 Jun 28, 2024
11 checks passed
@yonikid15 yonikid15 deleted the 7453-enable-no-unused-modules-on-ci branch June 28, 2024 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🛠️ Re-enable no-unused-modules eslint rule
3 participants