Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug - Link text to go to IAP homepage on browse IT jobs page #4558

Closed
2 tasks
mnigh opened this issue Nov 2, 2022 · 1 comment · Fixed by #4586
Closed
2 tasks

Bug - Link text to go to IAP homepage on browse IT jobs page #4558

mnigh opened this issue Nov 2, 2022 · 1 comment · Fixed by #4586
Assignees
@mnigh
Labels
bug Something isn't working. copy Content: What to say and how to say it.

Comments

@mnigh
Copy link
Contributor

mnigh commented Nov 2, 2022

Description

The link text to go to IAP homepage on browse IT jobs page does not include an action and does not lend itself to be translated well with <hidden> tags (used for providing context for screen readers) into French.

gc-digital-talent/frontend/talentsearch/src/js/components/Browse/BrowsePoolsPage.tsx

Line 281 in 66a95cf

"<hidden>Learn more about </hidden>Indigenous IT apprenticeship<hidden> opportunities</hidden>",

Screenshot

Screen Shot 2022-11-02 at 12 23 13

Acceptance Criteria

  • button text should fit in with nearby Visit the talent search page
  • button text should avoid using <hidden>
@mnigh mnigh added the copy Content: What to say and how to say it. label Nov 2, 2022
@mnigh mnigh mentioned this issue Nov 2, 2022
Merged
@mnigh mnigh added the bug Something isn't working. label Nov 2, 2022
@tristan-orourke
Copy link
Member

Copy the homepage

@mnigh mnigh self-assigned this Nov 3, 2022
@mnigh mnigh mentioned this issue Nov 3, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mnigh mnigh

Labels
bug Something isn't working. copy Content: What to say and how to say it.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Bug - Adds Link text to go to IAP homepage on Browse IT jobs page GCTC-NTGC/gc-digital-talent
2 participants
@mnigh @tristan-orourke