Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

9844 dev docker compose #10573

Closed
wants to merge 14 commits into from
Closed

9844 dev docker compose #10573

wants to merge 14 commits into from

Conversation

petertgiles
Copy link
Contributor

@petertgiles petertgiles commented Jun 3, 2024

πŸ€– Resolves #9844

πŸ‘‹ Introduction

Describe what this PR is solving.

πŸ•΅οΈ Details

Add any additional details that could assist with reviewing or testing this PR.

πŸ§ͺ Testing

Assist reviewers with steps they can take to test that the PR does what it says it does.

  1. ...
  2. ...

πŸ“Έ Screenshot

Add a screenshot (if possible).

🚚 Deployment

Add any additional details that are required for deploying the application.

Examples of when this is required include:

  • re-running database seeders
  • environment variable changes

Notes

  • Remove deployment section if no steps are needed
  • Add deployment label to the linked issue if deployment steps are needed

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests βœ…

Project coverage is 71.62%. Comparing base (2144101) to head (b7cd3e2).

Additional details and impacted files
@@              Coverage Diff              @@
##               main   #10573       +/-   ##
=============================================
+ Coverage     38.46%   71.62%   +33.15%     
  Complexity     1429     1429               
=============================================
  Files          1009      224      -785     
  Lines         30830     5511    -25319     
  Branches       6630        0     -6630     
=============================================
- Hits          11860     3947     -7913     
+ Misses        18794     1564    -17230     
+ Partials        176        0      -176     
Flag Coverage Ξ”
integrationtests 71.62% <ΓΈ> (ΓΈ)
unittests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

β˜” View full report in Codecov by Sentry.
πŸ“’ Have feedback on the report? Share it here.

@petertgiles
Copy link
Contributor Author

I'm going to put this down for a bit. Let's wait and see where #9840 goes.

@petertgiles petertgiles closed this Jul 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

πŸ› οΈ Separate docker-compose environment for development
2 participants