Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Remove indicator for rejected claims #10764

Merged
merged 3 commits into from
Jun 27, 2024

Conversation

JamesHuf
Copy link
Contributor

🤖 Resolves #10675

👋 Introduction

Prevents showing candidates in the pool candidate table and assessment tracker as veteran or priority if their claim has been rejected.

🧪 Testing

Assist reviewers with steps they can take to test that the PR does what it says it does.

  1. Navigate to a pool candidate table
  2. Confirm candidates with rejected veteran claims are not indicated as veteran
  3. Confirm candidates with rejected priority claims are not indicated as priority
  4. Navigate to the assessment tracker for a pool
  5. Confirm candidates with rejected veteran claims are not indicated as veteran
  6. Confirm candidates with rejected priority claims are not indicated as priority

@codecov-commenter
Copy link

codecov-commenter commented Jun 21, 2024

Codecov Report

Attention: Patch coverage is 45.83333% with 13 lines in your changes missing coverage. Please review.

Project coverage is 38.28%. Comparing base (92bf2f0) to head (fa776bc).

Files Patch % Lines
apps/web/src/utils/poolCandidate.ts 9.09% 10 Missing ⚠️
...onents/PoolCandidatesTable/PoolCandidatesTable.tsx 62.50% 3 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main   #10764      +/-   ##
============================================
- Coverage     38.28%   38.28%   -0.01%     
  Complexity     1649     1649              
============================================
  Files          1021     1021              
  Lines         31162    31178      +16     
  Branches       6507     6518      +11     
============================================
+ Hits          11930    11935       +5     
- Misses        19056    19067      +11     
  Partials        176      176              
Flag Coverage Δ
integrationtests 67.89% <ø> (ø)
unittests 31.15% <45.83%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@brindasasi brindasasi assigned brindasasi and unassigned brindasasi Jun 25, 2024
@brindasasi brindasasi self-requested a review June 25, 2024 15:05
Copy link
Contributor

@brindasasi brindasasi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking good! good to go 🥳

@JamesHuf JamesHuf added this pull request to the merge queue Jun 27, 2024
Merged via the queue into main with commit 90b330b Jun 27, 2024
11 of 12 checks passed
@JamesHuf JamesHuf deleted the 10675-hide-rejected-claims branch June 27, 2024 22:02
@brindasasi brindasasi restored the 10675-hide-rejected-claims branch June 28, 2024 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

✨ Claim rejection - remove indicator
3 participants