Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

upgrade storybook from 6.4 #3277

Merged
merged 1 commit into from
Jul 7, 2022
Merged

upgrade storybook from 6.4 #3277

merged 1 commit into from
Jul 7, 2022

Conversation

vd1992
Copy link
Contributor

@vd1992 vd1992 commented Jul 6, 2022 •
edited

resolves #2875
may resolves #3062

storybook appears to build without error now, as well per @mnigh research resolves a second issue
to test, ensure storybook builds successfully

@vd1992 vd1992 changed the title upgrade storybook upgrade storybook from 6.4 Jul 6, 2022
esizer
esizer approved these changes Jul 7, 2022
View reviewed changes
Copy link
Member

@esizer esizer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Working well on my end. Bounced around and did not see the :first-child warning as well. 🎉

@vd1992 vd1992 merged commit d840a63 into main Jul 7, 2022
@vd1992 vd1992 deleted the dependency/2875-upgrade-storybook branch July 7, 2022 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@esizer esizer esizer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Storybook - first-child is potentially unsafe. Upgrade Storybook from 6.4 to 6.5
2 participants
@vd1992 @esizer