Shorten to use Input instead of re-writing the code for it

GCheung55 · Aug 23, 2012 · 5bc3462 · 5bc3462
1 parent 251b8e2
commit 5bc3462
Showing 1 changed file with 17 additions and 32 deletions.
diff --git a/labs/architecture-examples/neuro/js/view/TodoListItem.js b/labs/architecture-examples/neuro/js/view/TodoListItem.js
@@ -24,8 +24,6 @@
              */
             events: {
                 'dblclick:relay(label)': 'onEdit',
-                // 'blur:relay(input.edit)': 'onUpdate',
-                // 'keyup:relay(input.edit)': 'onKeyup',
                 'click:relay(input.toggle)': 'onToggleStatus',
                 'click:relay(button.destroy)': 'destroy'
             },
@@ -63,16 +61,6 @@
             return this;
         },
 
-        update: function(value){
-            if (value) {
-                this.element.removeClass('editing');
-
-                this.fireEvent('update', ['title', value]);
-            }
-
-            return this;
-        },
-
         onUpdate: function(e, element){
             var value = element.get('value').trim();
 
@@ -91,23 +79,6 @@
             return this;
         },
 
-        onKeyup: function(e, element){
-            var key = e.key,
-                canUpdate = key == 'enter' || key == 'esc';
-
-            // Revert to the old value
-            if (key == 'esc') {
-                element.set('value', this._previousTitle);
-            }
-
-            // Update the label
-            if (canUpdate) {
-                this.element.fireEvent('blur', [e, element]);
-            }
-
-            return this;
-        },
-
         onToggleStatus: function(e, element){
             var hasClass = this.element.hasClass('completed');
             this.updateComplete(hasClass);
@@ -125,12 +96,12 @@
             }).getElement('>');
 
             this.setElement(element);
-var _this = this;
+
             var input = new View.Input({
                 element: element.getElement('input.edit'),
                 connector: {
-                    'keyup:enter': 'update',
-                    'keyup:reset': function(){_this.element.removeClass('editing');}
+                    'keyup:enter': '_onEnter'
+                    , 'keyup:reset': '_onReset'
                 }
             }).connect(this);
 
@@ -142,6 +113,20 @@ var _this = this;
 
             this.parent(model);
 
+            return this;
+        },
+
+        _onEnter: function(value){
+            if (value) {
+                this.fireEvent('update', ['title', value]);
+            }
+
+            return this;
+        },
+
+        _onReset: function(){
+            this.element.removeClass('editing');
+
             return this;
         }
     });