Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added my portfolio website #5

Merged
merged 10 commits into from
Oct 10, 2020
Merged

Added my portfolio website #5

merged 10 commits into from
Oct 10, 2020

Conversation

Alleny244
Copy link
Contributor

No description provided.

@pull-assistant
Copy link

pull-assistant bot commented Oct 1, 2020

Score: 0.69

Best reviewed: commit by commit


Optimal code review plan (2 warnings)

     Update README.md

     Update README.md

Update users.json

users.json 60% changes removed in Update users.json

     Update users.json

     Update users.json

Update users.json

users.json 50% changes removed in Update users.json

     Update users.json

     Update users.json

Powered by Pull Assistant. Last update e8d17d6 ... 46390cf. Read the comment docs.

@akshatvg
Copy link
Contributor

akshatvg commented Oct 1, 2020

@Alleny244 I had to change the users.json file to optimise the website.

Please make the required changes.

@Alleny244
Copy link
Contributor Author

@Alleny244 I had to change the users.json file to optimise the website.

Please make the required changes.

Yes I have made the required changes

@akshatvg
Copy link
Contributor

akshatvg commented Oct 3, 2020

@Alleny244 there's still a merge conflict. Please fix that.

@L04DB4L4NC3R
Copy link
Member

@Alleny244 I have resolved your conflict. Just add your portfolio image raw url in users.json and you will be good to go.

@Geek-ubaid Geek-ubaid requested review from akshatvg and removed request for akshatvg October 8, 2020 07:35
@Geek-ubaid
Copy link
Member

@Alleny244 do the changes requested, PR getting stale.

@Alleny244
Copy link
Contributor Author

@Alleny244 do the changes requested, PR getting stale.

Yes I Have updated the image url

@Alleny244
Copy link
Contributor Author

@Alleny244 I have resolved your conflict. Just add your portfolio image raw url in users.json and you will be good to go.

Yeah I have added it

@Alleny244
Copy link
Contributor Author

@Alleny244 do the changes requested, PR getting stale.

is it okay now?

@Geek-ubaid
Copy link
Member

@Alleny244 do the changes requested, PR getting stale.

is it okay now?

Yes it's fine.

@Geek-ubaid
Copy link
Member

All changes added merging it.

@Geek-ubaid Geek-ubaid merged commit 6eadc73 into GDGVIT:master Oct 10, 2020
@L04DB4L4NC3R L04DB4L4NC3R mentioned this pull request Oct 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants