Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added Linear Search #65

Merged
merged 5 commits into from
Oct 18, 2021
Merged

Added Linear Search #65

merged 5 commits into from
Oct 18, 2021

Conversation

ayushanand09
Copy link
Contributor

What was changed?

Checklist

  • Added description of change.
  • I acknowledge that all my contributions will be made under the project's license.

Program Request

  • Added file name matches File name guidelines mentioned in Contributing guidelines
  • Updated documentation OR created an issue for someone else to update the documentation.

Bug Fix

  • Bug is now fixed and program now behaves as expected.

Documentation Update

  • Documenation matches format mentioned in Contributing guidelines
  • If applicable, referenced sources have been linked.

Program Improvement

  • The improvements made are not just visual and actually makes the program more efficient.

Notes: This is with respect to issue number #11

@ayushanand09 ayushanand09 mentioned this pull request Oct 14, 2021
Closed
1 task
unshDee
unshDee suggested changes Oct 15, 2021
View reviewed changes
Copy link
Contributor

@unshDee unshDee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ayushanand09 you've added linear_search twice, one inside the searching folder and one in the root.
Please remove the one in root and I'll approve

@unshDee unshDee added hacktoberfest Related to hacktoberfest enhancement New program or feature labels Oct 15, 2021
@unshDee unshDee linked an issue Oct 15, 2021 that may be closed by this pull request
[PROG] Linear Search #11
Closed
1 task
@ayushanand09
Copy link
Contributor Author

Hey @unshDee ,
I have deleted "linear_search.cpp" file in the root.
Please do check it out.

Thanks,
Ayush

unshDee
unshDee approved these changes Oct 18, 2021
View reviewed changes
Copy link
Contributor

@unshDee unshDee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ayushanand09
Thanks! Approved

@unshDee unshDee merged commit 96ffc6f into GDSC-AUM:main Oct 18, 2021
@unshDee unshDee added the hacktoberfest-accepted Yay! Your PR got accepted! label Oct 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bhantsi bhantsi bhantsi approved these changes

@unshDee unshDee unshDee approved these changes

Assignees

@ayushanand09 ayushanand09

Labels
enhancement New program or feature hacktoberfest Related to hacktoberfest hacktoberfest-accepted Yay! Your PR got accepted!
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[PROG] Linear Search
3 participants
@ayushanand09 @bhantsi @unshDee