Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Android proxy implementation #17

Draft
wants to merge 9 commits into
base: master
Choose a base branch
from
Draft

Android proxy implementation #17

wants to merge 9 commits into from

Conversation

NiklasMerz
Copy link
Collaborator

@NiklasMerz NiklasMerz commented Jul 14, 2021

POST requests don't work on Android for now.

plugin.xml Outdated Show resolved Hide resolved
plugin.xml Show resolved Hide resolved
@mattdsteele
Copy link

@NiklasMerz Is there anything I can do to help get this merged and available? We're using this plugin for iOS purposes, but would like to update to Android 10's https protocol, and the proxy is the best approach we have to getting it working.

@NiklasMerz
Copy link
Collaborator Author

We stopped pursuing this idea of an Android proxy after we found our that Android's APIs make it impossible to do a POST request. It will still work for GET requests though.

Not sure if I would want the Android part if only GET works but if you or someone else needs this I would consider merging this.

@NiklasMerz NiklasMerz marked this pull request as draft January 6, 2022 18:34
@mattdsteele
Copy link

Yikes, that is... quite the limitation. I'm not sure it would be useful as GET only for our use case either.

Do you recall what the API limitation was? I wonder if there's anything we could learn from other implementations, like the Capacitor HTTP client: https://github.com/capacitor-community/http

@NiklasMerz
Copy link
Collaborator Author

This PR uses WebViewAssetLoader. This Android API is intended for app developers to load assets from the local file system with a proper origin.

Contrary to iOS these "path handlers" don't get information like the HTTP method used or request body. This is why we couldn't implement the proxy like on iOS.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants