Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

content assist after "Add" in Dialog #107

Closed
crapo opened this issue Apr 20, 2020 · 7 comments
Closed

content assist after "Add" in Dialog #107

crapo opened this issue Apr 20, 2020 · 7 comments

Comments

@crapo
Copy link
Collaborator

crapo commented Apr 20, 2020

@kittaakos , if you have time, could you investigate why there is no content assist available in a Dialog window after the keyword "Add" (or "add")? Should be able to reproduce with any small ontology. The content should be classes and properties.

@kittaakos
Copy link
Collaborator

why there is no content assist available

It's not implemented yet.

@crapo
Copy link
Collaborator Author

crapo commented Apr 20, 2020

Is this a lot of effort to implement? I guess I don't understand how much CA is inherited from sadl and how much is unique implementation in Dialog.

@kittaakos
Copy link
Collaborator

Is this a lot of effort to implement?

No, but I am still working on the rename/refactoring. (#104)

@crapo
Copy link
Collaborator Author

crapo commented Apr 20, 2020

Great!! :-) I am very excited about that major improvement!

@kittaakos
Copy link
Collaborator

The content should be classes and properties.

Did you mean SADL resources with either OntConceptType.CLASS or OntConceptType.CLASS_PROPERTY type? Can you please refine the requirements a bit? Thank you!

@crapo
Copy link
Collaborator Author

crapo commented Apr 20, 2020

So the definition of the statement starting with "Add" is:
NewExpressionStatement: ('Add'|'add') (newExpr=Expression ) ;
It isn't really that broad as it should probably be "real expressions", which in the SADL grammar start with ExpressionParameterized. In the shortterm, it would be very helpful if one could get a list of any SadlResource of type OntConceptType.CLASS, OntConceptType.CLASS_PROPERTY, or OntConceptType.RDF_PROPERTY. The latter two could have a range which is a class. But just the frist two would work for this week's objective.

kittaakos pushed a commit that referenced this issue Apr 22, 2020
Built-ins can be filtered with the `Filter SADL Implicit Model`
preference.

Closes: #107

Signed-off-by: Akos Kitta <kittaakos@typefox.io>
@kittaakos
Copy link
Collaborator

I have implemented it. It's part of #105.

screencast 2020-04-22 10-43-30

kittaakos pushed a commit that referenced this issue Apr 27, 2020
Built-ins can be filtered with the `Filter SADL Implicit Model`
preference.

Closes: #107

Signed-off-by: Akos Kitta <kittaakos@typefox.io>
@crapo crapo closed this as completed in b8847f1 Apr 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants