Skip to content

Commit

Permalink
fix incorrectly reported cryptocurrencies in SyscoinExtension
Browse files Browse the repository at this point in the history
  • Loading branch information
@rpanak-generalbytes
rpanak-generalbytes committed Jun 7, 2018
1 parent 66dfbb2 commit 9ec946f
Showing 1 changed file with 0 additions and 7 deletions.
7 changes: 0 additions & 7 deletions ...src/main/java/com/generalbytes/batm/server/extensions/extra/syscoin/SyscoinExtension.java
View file
Original file line number Diff line number Diff line change
Expand Up @@ -117,14 +117,7 @@ public IRateSource createRateSource(String sourceLogin) {
@Override
public Set<String> getSupportedCryptoCurrencies() {
Set<String> result = new HashSet<String>();
result.add(Currencies.BTC);
result.add(Currencies.SYS);
result.add(Currencies.BTX);
result.add(Currencies.BCH);
result.add(Currencies.LTC);
result.add(Currencies.XMR);
result.add(Currencies.DASH);
result.add(Currencies.POT);
return result;
}

Expand Down

2 comments on commit 9ec946f

@sidhujag
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so is dash wrong too then?

batm_public/server_extensions_extra/src/main/java/com/generalbytes/batm/server/extensions/extra/dash/DashExtension.java

Line 126 in 9ec946f

public Set<String> getSupportedCryptoCurrencies() {

@rpanak-generalbytes
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The thing is the DASH extension has the CoinmarketcapRateSource. When looking into this I realized that the extension XML doesn't match the code. The code works as expected (because of relaxed requirements for the extension descriptor) but it's definitely confusing.

Please sign in to comment.