Add code required so that the (recently added) P33(1600) resonance is not ignored by event generation modules #65
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sync with GENIE-MC/Generator master
… not ignored by event generation modules
ALso, fixed the bug with BaryonResonanceDecayer::IsHandled(), now returning the correct boolean flag instead of the input PDG code.
mroda88
approved these changes
Oct 18, 2019
There was a problem hiding this comment.
The changes are ok. The new values of the masses and of the width are compatible with PDG 2019.
The new decay channels are copied for the delta (1920). As a result two decay types are in the pdg_table but will never occur. Specifically
- decay into Nucleon + rho
- decay into Sigma + Kaon
Also, the PDG reports branching rations in nucleon + gamma which were not in the list of Delta(1920) and therefore are not in the list. These changes can be addressed at a later stage as an update of the resonance data was already suggested by Igor.
Sync with GENIE-MC/Generator master
|
The pull request mixed different things. Create a pull request specific for the RES fix |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.