Skip to content
This repository has been archived by the owner on Oct 26, 2021. It is now read-only.

ocf demo / Sandbox/pcoval/for/qemux86 64 #3

Merged

Conversation

rzr
Copy link
Contributor

@rzr rzr commented May 9, 2016

1 part to test workflow
this can be independently merged

@rzr
Copy link
Contributor Author

rzr commented May 9, 2016

I will test this patch set once the minnowboard branch land on github too

@rzr rzr force-pushed the sandbox/pcoval/for/qemux86-64 branch from 3fb2fc2 to 4ead6a7 Compare May 9, 2016 16:05
@rzr
Copy link
Contributor Author

rzr commented May 10, 2016

I tested successfully this patch set on minnowboard branch and documented how to replicate until it's merged :

https://at.projects.genivi.org/wiki/display/GDP/OCF

@as2902b

@tom--pollard
Copy link
Member

I've built and deployed this on the qemu branch, it 'works' to the extent at which I expect it to behave so it gets a +1 from me in that sense.

@rzr
Copy link
Contributor Author

rzr commented May 12, 2016

thx @tom--pollard , btw if @jeremiah can help to relocate https://github.com/TizenTeam/meta-genivi-ocf-demo to GENIVI GH then I will fixup the url , or do it after it will also work

@jeremiah
Copy link
Member

I've created: https://github.com/GENIVI/meta-genivi-ocf-demo

Does that help?

@rzr
Copy link
Contributor Author

rzr commented May 12, 2016

Thanks I will change url to the new one once merged

GENIVI/meta-genivi-ocf-demo#1

@as2902b

rzr added 3 commits May 13, 2016 13:59
Bug: https://at.projects.genivi.org/jira/projects/GOCF/issues/GOCF-27
Origin: https://github.com/TizenTeam/genivi-dev-platform/tree/sandbox/pcoval/for/qemux86-64
Change-Id: I06d10e14c2ec205c1ea7f7e754a3665fb505aefb
Signed-off-by: Philippe Coval <philippe.coval@osg.samsung.com>
Bug: https://at.projects.genivi.org/jira/projects/GOCF/issues/GOCF-27
Origin: https://github.com/TizenTeam/genivi-dev-platform/tree/sandbox/pcoval/for/qemux86-64
Change-Id: I6de44270e9c860eb2c54929fa76bb4160e7485dc
Signed-off-by: Philippe Coval <philippe.coval@osg.samsung.com>
Change-Id: I714105c3266b99fc3fa9e8b07d9236ce0d27c9b6
Origin: https://github.com/TizenTeam/genivi-dev-platform/tree/sandbox/pcoval/for/qemux86-64
Signed-off-by: Philippe Coval <philippe.coval@osg.samsung.com>
@rzr rzr force-pushed the sandbox/pcoval/for/qemux86-64 branch from 4ead6a7 to 941dd79 Compare May 13, 2016 11:59
@rzr
Copy link
Contributor Author

rzr commented May 13, 2016

as @tom--pollard suggested iotivity layer can be integrated first without demos

@gunnarx
Copy link
Member

gunnarx commented May 13, 2016

The maintainers ultimately decide, but personally I'm opposed to including anything that is not yet being used in GDP. There is a big chance that actually exercizing the functionality becomes delayed and we just build up cruft in our project. As of today I think iotivitiy is only a dependency needed for the OCF demo.

The alternative is demonstrating something that fully works, i.e the "demo", then asking if we want that functionality exposed in GDP (which would likely need that most users have access to any hardware the demo needs and other aspects), and assuming there is a decision to include it, then integrate the whole function together with its needed dependencies.

@tom--pollard
Copy link
Member

@rzr my point was that I think ocf-demo should be a part of meta-genivi-dev, as it's mainly just adding to the genivi-dev-platform bb image

@rzr
Copy link
Contributor Author

rzr commented May 13, 2016

Well merging components one per one would make cooperation smoother or easier, that's why I wanted to start with this simple iotivitymap app to validate the "development" platform.

Who to bother to decide if meta-oic is part of GDP or should stay in demo layer ?

@tom--pollard
Copy link
Member

meta-oic is fine as a seperate layer imo, it's the ocf demo layer that seems excessive as it's own standalone layer

@jonathanmaw
Copy link
Contributor

I am also in favour of merging this now, to make it easier to get the ocf demo merged later.

@rzr
Copy link
Contributor Author

rzr commented May 16, 2016

@jonathanmaw Good this was my plan too

@tom--pollard expect more to come into genivi-oicf layer (RVI gateway etc) as the moment there is just a basic sample to validate iotivity on gdp and then we'll can integate the remaining stuff , ok ?

I am adding @toscalix to this thread, to track this PR too

@as2902b
Copy link

as2902b commented May 16, 2016

IMHO, getting meta-oic to be part of the GDP is an important first step.
The OCF gateway & OCF servers can be part of the meta-genivi-ocf-demo. These are the key building blocks for the demo.
The Android, Tizen mobile and Gear S2 apps can be independently hosted in a public repo, since it is only for validation/example purpose.

Having an meta-oic integrated GDP gives us the flexibility to deploy the OCF-RVI gateway within GDP, without the need for a separate entity to host the gateway. It is one of the deployment models we have in mind.

Note : We use OIC and OCF interchangeably since the organization has been renamed recently.

@tom--pollard
Copy link
Member

I presume you would want meta-oic merged to all target branches?

@rzr
Copy link
Contributor Author

rzr commented May 17, 2016

In any branch you want to let us continue the integration part.

I can work on qemu , minnow or rpi ..

@jonathanmaw
Copy link
Contributor

Merging to all branches, in anticipation of patches to meta-genivi-dev which will add the ocf demo (so this patch can be properly exercised)

@jonathanmaw jonathanmaw merged commit 5ac63e9 into GENIVI:qemux86-64 May 17, 2016
@gunnarx
Copy link
Member

gunnarx commented May 18, 2016

I'm ok if you want to actual git merges in steps, just long as the complete function exists and has been decided to be merged. For any function (not OCF specifically) as I said the decision to include it in entirety depends on the value of the function, the ability for all (most) users to appreciate and run the function (any special hardware required?) and so on. Such a decision I think ought to be discussed on the GDP call as a feature prioritization thing. In this case we saw it at AMM but in other cases demonstrating it on the meeting over WebEx, a short movie or whatever would make sense to convince everyone it should be included.

But today's call also opened the idea about optional features, and we might improve our understanding of how to handle such features in a good way.

@gunnarx
Copy link
Member

gunnarx commented May 18, 2016

+1 on keeping layers separate, generally speaking.

@sanbeam sanbeam mentioned this pull request May 26, 2016
chbae pushed a commit to chbae/genivi-dev-platform that referenced this pull request Jun 19, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
6 participants