Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding SourceFluxStatistics #2954
Adding SourceFluxStatistics #2954
Changes from 54 commits
d73ac6d
909a1c5
8bee3cf
256caeb
0ec69b5
67d8a7e
27bec78
f89e2d8
e0592ed
078e6ed
5b8f213
953ec3a
1a9fe0c
867a20c
814fd34
818fcc2
a5d762b
28a7730
4e71130
cc55358
69c6918
a164ece
badfc4e
23e41fc
d59318a
db72798
232106b
8477262
317560a
af7be1e
796f020
c6ccc63
b806da7
aa4b250
c2fa0f8
dc3398c
c2c74f0
0a0fb7b
e2ac446
4c3fa0b
41b0fc8
f163aed
1781ac9
620a53b
45f7452
703b73a
cdebcff
ffcf39b
7a96ee2
2446436
a0d085a
e427189
e1e79cf
3da5569
e9f7f4a
6af8726
3d19803
a2d618a
7ee9b4d
7378ec2
322a3f8
0161b19
d6a47d8
c528da8
5907f9c
720c493
afab7c7
1e33b3d
f911df3
8dfe5db
2662637
7fcf887
ffaf9d4
e9ee4ea
a9d17d4
2003fd2
45084b5
000978a
923b0d8
02d35fc
f53a8f5
d5b4a14
fad3edf
68eb991
9b0628f
adab7a0
32cdd5e
42a57d8
7f2a913
7f51542
dc5b827
7f9097c
de20aba
9f78b8d
25bc30f
f56b2f6
37b3c97
3165aef
9905ae1
3883d39
8f72e9f
43fe9f4
34fc78d
cf15bb3
b051ed1
cf0271a
b0c7fe6
db2efea
ce24a37
fc11f5b
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If the
logLevel
is low enough, then we don't need to create these wrappers.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I use them to collect stats from the
SinglePhaseBase::applySourceFluxBC()
methods that have no knowledge of the regions. Can I keep them to collect the data or should I proceed differently?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi, I'd be interested in decoupling the gathering/aggregation of the data from its output.
Here we impose
log
andcsv
, for example. There's no reason not to use theCSV
for other types of data, and to imposeCSV
for the source flux data.@MelReyCG , I had a quick chat with @arng40 about that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just to notify everyone about the conclusion of our chat on this subject:
Outputs
new node could be created to output those stats, maybe something like:There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You need to be sure that this is called by all the ranks. Is it the case?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Indeed, I tested that all ranks send & combine how much the
SourceFlux
produced / injected (possibly 0).