Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates for Stratospheric Transport #42

Closed
wants to merge 7 commits into from

Conversation

sdrabenh
Copy link
Contributor

@sdrabenh sdrabenh commented Dec 5, 2023

No description provided.

@sdrabenh sdrabenh added the 0 diff trivial The changes in this pull request are trivially zero-diff (documentation, build failure, &c.) label Dec 5, 2023
@sdrabenh sdrabenh self-assigned this Dec 5, 2023
@sdrabenh sdrabenh requested a review from a team as a code owner December 5, 2023 15:43
mathomp4
mathomp4 previously approved these changes Dec 5, 2023
@mathomp4
Copy link
Member

mathomp4 commented Dec 5, 2023

@sdrabenh You might as well add a CHANGELOG entry now so you don't forget! :)

mathomp4
mathomp4 previously approved these changes Dec 7, 2023
@mathomp4
Copy link
Member

mathomp4 commented Dec 7, 2023

There seems to be a bug in flat2hdf.F:

/root/project/GEOSgcm/src/Shared/@GMAO_Shared/@GEOS_Util/post/flat2hdf.F:177:132:

  177 |                  write(6,1002) n,trim(fname(n))
      |                                                                                                                                    1
Error: FORMAT label 1002 at (1) not defined

but, uh, that is defined on line 181.

@tclune Any idea what GNU is annoyed by?

@tclune
Copy link
Contributor

tclune commented Dec 7, 2023

The thing that catches my eye is that i is not a valid edit descriptor on its own. NAG would complain about that. But (1) I don't recall GFortran complaining about such things, and (2) I would think it is a run time thing, not a compile time thing.

The text of the error message suggests the compiler does not see the FMT at 1002, which is just bizarre.

Sorry not much help. But changing to i0 is worth fixing in any event.

@sdrabenh sdrabenh closed this Feb 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0 diff trivial The changes in this pull request are trivially zero-diff (documentation, build failure, &c.)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants