R21C landice history changes #371
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lcandre2
assigned elakkraoui, lltakacs, sdrabenh, rcullath, gmao-rreichle and zhaobin74
Please run with the code/build from "develop" (not from S2S v3). 🙏 If need assistance don't hesitate to ask. |
sanAkel
added
the
Contingent - DNA
Add |
|
Closing this pull request because I merged |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This request is associated with PR#664 in the GEOSgcm_GridComp.
These changes touch flx and glc collections and are associated with changes in the SURFACE grid comp and children (see
PR#356 for points referenced below).
I introduced the following changes:
Added the cube sphere collection for glc and modified the lat/lon collection name.
Added 13 additional variables to the glc collection. In instances where the variable name could be confused with other variables from different collections, the name has an appended ‘GLC’. This point also includes two modifications to long names/description of landice specific outputs in the grid comp.
Added ‘RUNOFF’ from ‘SURFACE’ to the flx collections. This variable exports the combined land and landice runoff. I also proposed the name ‘RUNOFFTOT’ to distinguish it from ‘RUNOFF” which is the variable name for the ‘RUNSURF’ export in the lnd and other collections. This addresses point 2 in #PR356. Note that other collections use RUNSURF for RUNOFF and it is unclear if ‘RUNOFF/RUNOFFTOT’ should be used.
Added ‘GHTSKIN’ from ‘SURFACE’ to the flx collections and proposed the name ‘GHTFLX’. There is a landice grid comp modification to correct a sign issue and support this addition.
Added ‘ALBNF’ and ‘ALBVF’ from ‘SURFACE’ to the rad collections and proposed the names ‘REFLNIRDF’ and ‘REFLVISDF’ to distinguish them from the ‘SOLAR’ exports. This addresses issues with the ‘SOLAR’ exports and point 4 in #PR356. This change also includes a modification to the long name/description (albedo —> reflectivity) in the SURFACE grid comp and children (Land, Landice, Saltwater, etc).
Changed the long names/descriptions for AICE/OFRACI and FRSEAICE/FRACI to
Outstanding issues:
Note that multiple collections use RUNSURF for RUNOFF and it is unclear if RUNOFF/RUNOFFTOT should be used. A model run during NH summer would be useful to confirm that RUNOFF is exporting the combined runoff correctly. It currently does in S2S. Will confirm with a run.
DRPAR & DFPAR outputs from SOLAR vs SURFACE. Are they the same - will confirm with a run.
Let me know if any issues arise or if there are any questions or comments.