Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhance the setup scripts, particularly GMI and StratChem wrt GOCART2G #445

Merged
merged 3 commits into from
May 10, 2023
Merged

Enhance the setup scripts, particularly GMI and StratChem wrt GOCART2G #445

merged 3 commits into from
May 10, 2023

Conversation

mmanyin
Copy link
Contributor

@mmanyin mmanyin commented Apr 17, 2023

This PR enables GMI and StratChem to operate with AERO_PROVIDER == GOCART2G. Zero-diff for PCHEM experiments.

@mmanyin mmanyin added the 0 diff The changes in this pull request have verified to be zero-diff with the target branch. label Apr 17, 2023
@mmanyin mmanyin requested a review from a team as a code owner April 17, 2023 21:04
mathomp4
mathomp4 approved these changes Apr 18, 2023
View reviewed changes
Copy link
Member

@mathomp4 mathomp4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because @sdrabenh is busy, I tested gcm_setup with both actual and climatological GOCART and it was happy.

No idea about the other two, but those are definite Trust in Mike™ files. 😄

@sdrabenh sdrabenh merged commit 4df8ba1 into develop May 10, 2023
@sdrabenh sdrabenh deleted the feature/mmanyin/setup_mods branch May 10, 2023 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mathomp4 mathomp4 mathomp4 approved these changes

@sdrabenh sdrabenh sdrabenh approved these changes

Assignees
No one assigned
Labels
0 diff The changes in this pull request have verified to be zero-diff with the target branch.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mmanyin @mathomp4 @sdrabenh