Sync develop into main #588
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…DT=450 validation
…BEAT_DT=450 validation
This commit introduces a logical variable 'wavewatch'. Said flag controls the handling of WAVEWATCH namelists and restarts in the gcm_run.j script.
Improve readability
Get rid of unnecessary linking of files.
…-waves Initialize USE_WAVES to 0
…ress Use nccmp, add readers/writers test to regress
Disable Catchment-CN4.5 land model option (LSM_CHOICE=3) for GCM simulations
…adas add surface forcing lfo_Nx+- to HISTORY.rc.tmpl
Do not link unnecessary files!
Use CMake to determine MPI Stack
Testing by @sanAkel and @rtodling found that `IS_FCST` was a resource parameter in both the AGCM Grid Comp and in the DataSea and DataIce Grid Comps that was doing different things. In the DataSea and DataIce Grid Comps, it determined persistence of SST/ICE via `MAPL_ReadForcing`. But in the AGCM, it altered IAU handling (I think?). Either way, there was no good way to set one without setting the other. So, for separability, we rename all the oceanic `IS_FCST` to be `OGCM_IS_FCST`. We keep the AGCM `IS_FCST` as it currently is named unless there is a desire to refactor it from @sdrabenh or others.
Feature/pnorris/rrtmgp validation
Feature/pnorris/rrtmgp v1.7
Refactor DataSea/DataIce IS_FCST to OGCM_IS_FCST
sdrabenh
added
the
0 diff
mathomp4
approved these changes
Mar 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.