Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync qr/qs export naming to corresponding changes in MOIST (exports) #605

Merged
merged 3 commits into from
May 7, 2024

Conversation

rtodling
Copy link
Contributor

@rtodling rtodling commented May 6, 2024

These changes are to make consistent the changes made in v2.5.3 of GCM - it would be nice to have these tagged: v2.3.3 - since the changes are being put on top of what was v2.3.2

Notice that these changes are zero-diff - contrary to the original changes when GCM was at v2.5.2.

@rtodling rtodling requested a review from a team as a code owner May 6, 2024 15:57
@rtodling rtodling added the 0 diff The changes in this pull request have verified to be zero-diff with the target branch. label May 6, 2024
@mathomp4
Copy link
Member

mathomp4 commented May 6, 2024

@rtodling

Note that because this is going to develop that means you would get the changes from #544 which moved the scripting to use the new bcs directories. This was/is zero-diff, but it means v2.3.3 would have both this change and the new bcs.

Is that okay? Or would you prefer v2.3.3 to just have this?

Note, v11.5.3 would probably have everything in develop here anyway, but if you'd prefer separation in that order (history before setup) so you could have a v2.3.3 and then a v2.3.4 (which would probably go into v11.5.3), I can work with @sdrabenh to do that.

@sdrabenh
Copy link
Collaborator

sdrabenh commented May 6, 2024

@mathomp4 @rtodling I should have read this more carefully before updating the branch. Sorry, I was rushing on lunch break to get things moving. We can revert the last commit if @rtodling wants a spinoff without updated BCS directory. Just let us know what is preferred.

Well, eventually it would get into develop. But if there needs to be a separation, we'd just apply these changes in a new PR to main and then merge up and...this PR would auto-magically close :)

@sdrabenh sdrabenh merged commit 4caff8c into develop May 7, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0 diff The changes in this pull request have verified to be zero-diff with the target branch.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants