Skip to content

Commit

Permalink
edited comments, cleanup
Browse files Browse the repository at this point in the history
  • Loading branch information
gmao-rreichle committed Jul 13, 2022
1 parent 4274beb commit 13b0b0c
Show file tree
Hide file tree
Showing 3 changed files with 37 additions and 18 deletions.
17 changes: 14 additions & 3 deletions src/Applications/LDAS_App/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -19,13 +19,24 @@ ecbuild_add_executable (
SOURCES util/inputs/mwrtm_bin2nc4.F90
LIBS GEOSlandassim_GridComp)

install(
PROGRAMS ldas_setup process_hist.csh process_rst.csh ens_forcing/average_ensemble_forcing.py ens_forcing/ensemble_forc.py ens_forcing/regrid_forc.csh ens_forcing/enpert_forc.csh
set (scripts
ldas_setup
process_hist.csh
process_rst.csh
ens_forcing/average_ensemble_forcing.py
ens_forcing/ensemble_forc.py
ens_forcing/regrid_forc.csh
ens_forcing/enpert_forc.csh
)

install (
PROGRAMS ${scripts}
DESTINATION bin
)

file(GLOB rc_files GEOSldas_*rc)
file(GLOB rc_files GEOSldas_*rc)
file(GLOB nml_files LDASsa_DEFAULT*nml)

install(
FILES ${rc_files} ${nml_files} lenkf.j.template
DESTINATION etc
Expand Down
4 changes: 2 additions & 2 deletions src/Applications/LDAS_App/ens_forcing/enpert_forc.csh
Original file line number Diff line number Diff line change
Expand Up @@ -13,8 +13,8 @@
# Requires environment variables:
# ADAS_EXPDIR - path the ADAS experiment directory (ensemble of lfo files)
# GRID - target grid of forcing files (typically that of deterministic ADAS simulation)
# NENS - number of ensemble members (ensemble size, typically that of LDAS coupled to the deterministic ADAS)
# GEOSBIN - GEOSldas ROOTdir ( typically GEOSldas/install/bin )
# NENS - number of (LDAS) ensemble members (<= number of ADAS ensemble members)
# GEOSBIN - GEOSldas "ROOT" directory (typically GEOSldas/install/bin)
#
# Input data sets:
# 1. lfo files from coarse-resolution ADAS ensemble
Expand Down
34 changes: 21 additions & 13 deletions src/Applications/LDAS_App/ens_forcing/test_enpert_forc.j
Original file line number Diff line number Diff line change
@@ -1,31 +1,39 @@
#!/usr/bin/csh

# sample script for testing "enpert_forc.csh"
#
# must edit paths before submitting this script
#
# -----------------------------------------------------------

#SBATCH --ntasks=1
#SBATCH --time=1:00:00
#SBATCH --job-name=regd
#SBATCH --output=/discover/nobackup/user/test/test.o%j.txt
#SBATCH --job-name=test_enpert_forc
#SBATCH --output=/discover/nobackup/[USER]/test_enpert_forc.o%j.txt
#SBATCH --export=NONE
#SBATCH --qos=debug

########################################################
## user: user
## GEOSldas: GEOSldas ROOTdir
## testdir: user testdir
## GEOSadas: GEOSadas ROOTdir
########################################################
# set environment variables needed by enpert_forc.csh

setenv GEOSBIN /discover/nobackup/[USER]/GEOSldas/install/bin
setenv ADAS_EXPDIR /discover/nobackup/[USER]/GEOSadas
setenv NENS 24
setenv GRID PE180x1080-CF

# load modules

setenv GEOSBIN /discover/nobackup/user/GEOSldas/install/bin
source $GEOSBIN/g5_modules

module load python/GEOSpyD/Ana2019.03_py3.7

if ( -e /etc/os-release ) then
module load nco/4.8.1
else
module load other/nco-4.6.8-gcc-5.3-sp3
endif

setenv RUNDIR /discover/nobackup/user/testdir/
setenv ADAS_EXPDIR /discover/nobackup/user/GEOSadas
setenv NENS 24
setenv GRID PE180x1080-CF
# execute test

$GEOSBIN/enpert_forc.csh

# ====================== EOF ===================================

3 comments on commit 13b0b0c

@saraqzhang
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

my original comment ## GEOSadas: GEOSadas ROOTdir is wrong.
it should be ## GEOSadas: Hy4DEnVar exp home dir ( as in adas FVHOME )
So in the current version we should have something like
setenv ADAS_EXPDIR /discover/nobackup/[USER]/[adas_exphome]

@gmao-rreichle
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@saraqzhang, I'm not sure I really understand your comment and what needs to change where, but I took a crack at it in 71f7915 - does this address your concern?

@saraqzhang
Copy link
Contributor

@saraqzhang saraqzhang commented on 13b0b0c Jul 13, 2022 via email

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please sign in to comment.