Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

boundary conditions install dir issue #686

Closed
biljanaorescanin opened this issue Nov 29, 2023 · 3 comments
Closed

boundary conditions install dir issue #686

biljanaorescanin opened this issue Nov 29, 2023 · 3 comments

Comments

@biljanaorescanin
Copy link
Contributor

With addition of milan nodes scripts were updated to create install directory with new name to separate builds on SLES-12 and SLES-15. This produces our make_bcs.py package to report error can't find install/bin dir.

For example cube grid in make_bcs_cube.py:

if 'install/bin' not in bin_dir:
print(" please run this program in installed bin directory")
return

@biljanaorescanin
Copy link
Contributor Author

biljanaorescanin commented Dec 4, 2023

@weiyuan-jiang with merge of this PR (#681) we now have same issue with GEOSldas as we do with GEOSgcm , we can't run make_bcs.py package since it can't find install/bin dir since now it is install-SLES12/bin .

@gmao-rreichle Is the plan to add fix for this on top of this PR(#680)?

@gmao-rreichle
Copy link
Contributor

@gmao-rreichle Is the plan to add fix for this on top of this PR(#680)?

Maybe it's better if we have a separate PR for the Milan/SLES-12/SLES-15 fixes, but it's ok with me if we add it on top of #680. In the latter case, please make sure to update the intro comment of #680

@gmao-rreichle
Copy link
Contributor

addressed with GEOS-ESM/GEOSgcm_GridComp#870

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants