Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adapt to new bcs structure #680

Merged
merged 15 commits into from
Feb 21, 2024
Merged

Conversation

weiyuan-jiang
Copy link
Contributor

@weiyuan-jiang weiyuan-jiang commented Oct 25, 2023

For this PR, the input file's BCS_PATH should just include the bc version like:

  1. BCS_PATH: /discover/nobackup/projects/gmao/bcs_shared/fvInput/ExtData/esm/tiles/NL3/
  2. And the resolution should not have prefix 'SMAP_' (Issue EASE grid name change #673 )
  3. Needs GEOS_Util's Assorted enhancements of remap_restarts.py package (EASE, SLES15, NAS, lake/landice log) GEOS_Util#43

@mathomp4 : A heads-up, we will need to update the GEOSldas nightly tests after merging this PR to accommodate the new bcs dir structure.

@biljanaorescanin
Copy link
Contributor

With GEOS_Util branch feature/wjiang/command_line and two more changes in input files all nightly tests passed.
Changes needed in the input files of the Nightly Tests:

  1. BCS_PATH has to be updated in all *.exec scripts to new layout path.
  2. For assim tests we need to change directory name where we search for mwrtm_path.
    We need to drop SMAP from SMAP_EASEv2_M09
    (*/LDAS_Restarts/NGHTLY_TST_TV4000/SMAP_EASEv2_M09 needs to become */LDAS_Restarts/NGHTLY_TST_TV4000/EASEv2_M09)

@weiyuan-jiang
Copy link
Contributor Author

With GEOS_Util branch feature/wjiang/command_line and two more changes in input files all nightly tests passed. Changes needed in the input files of the Nightly Tests:

  1. BCS_PATH has to be updated in all *.exec scripts to new layout path.
  2. For assim tests we need to change directory name where we search for mwrtm_path.
    We need to drop SMAP from SMAP_EASEv2_M09
    (*/LDAS_Restarts/NGHTLY_TST_TV4000/SMAP_EASEv2_M09 needs to become */LDAS_Restarts/NGHTLY_TST_TV4000/EASEv2_M09)

Is mwRTM_param.nc4 file included in BCS ?

@biljanaorescanin
Copy link
Contributor

With GEOS_Util branch feature/wjiang/command_line and two more changes in input files all nightly tests passed. Changes needed in the input files of the Nightly Tests:

  1. BCS_PATH has to be updated in all *.exec scripts to new layout path.
  2. For assim tests we need to change directory name where we search for mwrtm_path.
    We need to drop SMAP from SMAP_EASEv2_M09
    (*/LDAS_Restarts/NGHTLY_TST_TV4000/SMAP_EASEv2_M09 needs to become */LDAS_Restarts/NGHTLY_TST_TV4000/EASEv2_M09)

Is mwRTM_param.nc4 file included in BCS ?

Nope, it is in area I gave path to in upper comment. Currently its here: */LDAS_Restarts/NGHTLY_TST_TV4000/SMAP_EASEv2_M09/mwRTM_param.nc4

@weiyuan-jiang
Copy link
Contributor Author

This PR should work with this GEOS_Util branch

@biljanaorescanin

This comment was marked as off-topic.

@gmao-rreichle

This comment was marked as off-topic.

@gmao-rreichle gmao-rreichle marked this pull request as ready for review February 21, 2024 23:02
@gmao-rreichle gmao-rreichle requested review from a team as code owners February 21, 2024 23:02
@gmao-rreichle gmao-rreichle merged commit 434da27 into develop Feb 21, 2024
6 of 7 checks passed
@gmao-rreichle gmao-rreichle deleted the feature/wjiang/new_bcs_structure branch February 21, 2024 23:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants