Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

checkpoint files are geneareted by GEOSldas #182

Merged
merged 4 commits into from
Apr 22, 2020
Merged

checkpoint files are geneareted by GEOSldas #182

merged 4 commits into from
Apr 22, 2020

Conversation

weiyuan-jiang
Copy link
Contributor

@weiyuan-jiang weiyuan-jiang commented Apr 21, 2020 •
edited by gmao-rreichle
Loading

This pull request addresses two things:

  • Don't need the line directing the landpert checkpoint output when on cube-sphere tiles
  • Create directories from within F90 executable for ObsFcstAna files. (Facilitates extending an existing GEOSldas run without going through setup.) This will be revamped later on so that all files are created in ./scratch and then cleaned up in post-processing.

@weiyuan-jiang weiyuan-jiang requested a review from a team as a code owner April 21, 2020 12:33
@weiyuan-jiang
Copy link
Contributor Author

We can replace the non-standard "system" call with a standard "excute_command_line" call. That should not cause problems.

@gmao-rreichle
Copy link
Contributor

Not sure how much protection is provided by "execute_command_line()"
It looks like it's only a wrapper for the "system()" call, and it may not be available in all compilers.
https://gcc.gnu.org/onlinedocs/gfortran/EXECUTE_005fCOMMAND_005fLINE.html
https://www.pgroup.com/userforum/viewtopic.php?t=6422
We could use it as a temporary solution.
In the long run, shouldn't we handle the files in ana/ just like HISTORY files, i.e., write them into scratch/ and clean up in post-processing?
(Note that the subroutines in "clsm_ensupd_read_obs.F90" that still contained "system()" calls are not currently in use but need to be overhauled before the land analysis can be integrated into the next GMAO reanalysis.)

@weiyuan-jiang
Copy link
Contributor Author

This intrinsic call is Fortran 2008 standard. So for the long run, it should be fine. But I don't oppose to send data from scratch to the destination. I just need more information to understand the file name format and where to send. The original codes have dealt with all the cases that I may never see in the limited test cases. So it is much easier to change the original codes.

@gmao-rreichle
added comment to bug fix for LANDPERT checkpoint
5441d5b 
bug fix: addressed setting up LANDPERT checkpoint file for cube-sphere tile space
gmao-rreichle
gmao-rreichle approved these changes Apr 22, 2020
View reviewed changes
Copy link
Contributor

@gmao-rreichle gmao-rreichle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note: Fix for creating directories from within F90 is only temporary and will be cleaned up later.

@gmao-rreichle gmao-rreichle merged commit dc75417 into develop Apr 22, 2020
@gmao-rreichle gmao-rreichle deleted the bugfix/landpert_checkpoint branch April 22, 2020 14:36
@gmao-rreichle gmao-rreichle linked an issue Apr 22, 2020 that may be closed by this pull request
Create necessary directories in post-processing #175
Closed
@gmao-rreichle gmao-rreichle mentioned this pull request Apr 22, 2020
Closed
gmao-rreichle added a commit that referenced this pull request Apr 23, 2020
@gmao-rreichle
Syncing develop into BRIDGE_FROM_DEVELOP_TO_MASTER (#188)
4e8d4cf 
* fix gnu debug (#178)

* checkpoint files are geneareted by GEOSldas  (#182)

* checkpoint files are generated by GEOSldas ( not MAPL) when on cubed-sphere tile space

* create year/month directories for ldas_ObsFcstAna from within GEOSldas executable

* change system() calls to Fortran2008 standard Execute_command_line()

* subdaily2daily concatenation;  SLES12 sbatch fix

- Added sbatch submission for pre-processing of restarts to comply with SLES12 requirements.
- Subdaily-to-daily nc4 file concatenation now processes before the month is complete.

* pass in optional account through ldas_setup (#184)

* updating to MAPL 2.1.1 (updated ESMA_env and cmake)

* Resurrecting SMAP L1C Tb fore-minus-aft check
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gmao-rreichle gmao-rreichle gmao-rreichle approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Create necessary directories in post-processing
2 participants
@weiyuan-jiang @gmao-rreichle