Update to MAPL 2.34.1, ESMA_cmake 3.24.0 #618
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates GEOSldas to use MAPL 2.34.1. The impetus for this is the that we discovered a bug in how MAPL handled 4D variables in restarts when
WRITE_RESTART_BY_OSERVER: YES
was set. Now in GEOSgcm this is automatically set when Open MPI is the MPI stack (which is true for GNU at NCCS). I'm not sure if the LDAS uses that setting (@weiyuan-jiang might know).I also don't know if the LDAS has any 4D variables in its restarts, but it is possible if there are 2 ungridded dims in a variable (since I assume 🤷🏼 that the LDAS is mainly 2d variables discounting ungridded dims).
Also, this will bring in MAPL 2.34.0 changes as well. Per the release notes, I don't think anything in 2.34 directly affects the LDAS, so I'll mark this as zero-diff, but @biljanaorescanin will of course test.
Also also, I'm updating ESMA_cmake to 3.24.0. Per the changelog, this is very minor.