Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to MAPL 2.34.1, ESMA_cmake 3.24.0 #618

Merged
merged 1 commit into from
Jan 13, 2023

Conversation

mathomp4
Copy link
Member

@mathomp4 mathomp4 commented Jan 13, 2023

This PR updates GEOSldas to use MAPL 2.34.1. The impetus for this is the that we discovered a bug in how MAPL handled 4D variables in restarts when WRITE_RESTART_BY_OSERVER: YES was set. Now in GEOSgcm this is automatically set when Open MPI is the MPI stack (which is true for GNU at NCCS). I'm not sure if the LDAS uses that setting (@weiyuan-jiang might know).

I also don't know if the LDAS has any 4D variables in its restarts, but it is possible if there are 2 ungridded dims in a variable (since I assume 🤷🏼 that the LDAS is mainly 2d variables discounting ungridded dims).

Also, this will bring in MAPL 2.34.0 changes as well. Per the release notes, I don't think anything in 2.34 directly affects the LDAS, so I'll mark this as zero-diff, but @biljanaorescanin will of course test.

Also also, I'm updating ESMA_cmake to 3.24.0. Per the changelog, this is very minor.

@mathomp4 mathomp4 self-assigned this Jan 13, 2023
@mathomp4 mathomp4 requested a review from a team as a code owner January 13, 2023 15:57
@gmao-rreichle
Copy link
Contributor

Thanks, @mathomp4, for keeping us current. I am running the tests now, @biljanaorescanin is away.
I don't think we have variables with 2 ungridded dims, and I don't expect any of the changes will impact the LDAS.
With any luck, we'll know for sure by the end of the day.

Copy link
Contributor

@gmao-rreichle gmao-rreichle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All tests passed. I'll go ahead and merge.

@gmao-rreichle gmao-rreichle merged commit 1bb45c4 into develop Jan 13, 2023
@gmao-rreichle gmao-rreichle deleted the feature/mathomp4/update-to-MAPL-2.34.1 branch January 13, 2023 20:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants