add checks on snow states after application of LDAS increments #676
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eck_after_apply_LDAS_incr
…ain 0-diff of SMAP Tb DA test case)
|
This PR is being prevented from merging because you have added one of our blocking labels: Contingent - DNA, Needs Lead Approval, Contingent -- Do Not Approve. You'll need to remove it before this PR can be merged. |
gmao-rreichle
commented
Sep 30, 2023
components.yaml
Outdated
| @@ -41,6 +41,6 @@ MAPL: | |||
| GEOSgcm_GridComp: | |||
| local: ./src/Components/GEOSldas_GridComp/@GEOSgcm_GridComp | |||
| remote: ../GEOSgcm_GridComp.git | |||
| branch: develop | |||
| branch: feature/rreichle/snow_check_after_apply_LDAS_incr | |||
There was a problem hiding this comment.
@biljanaorescanin: Make sure to restore components.yaml from the develop branch before merging this PR.
biljanaorescanin
approved these changes
Oct 18, 2023
biljanaorescanin
deleted the
feature/rreichle/snow_check_after_apply_LDAS_incr
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR restores 0-diff of LDAS assim tests after merger of eponymous GEOS-ESM/GEOSgcm_GridComp#834.
0-diff is maintained by turning off the new snow checks in the 3d Tb-based soil moisture analysis for now.
#834 also introduces new exports (FICE[n]). They have not yet been added into GEOS_EnsGridComp.F90. It is unclear if that should be done. (The ens avg of FICE may not be meaningful.) This can be left for a later PR.
Successfully tested by @gmao-rreichle some time ago. Needs retesting as of 6 Oct 2023
Retested successfully for GEOSldas Intel-only on Oct 15 by @gmao-rreichle
Fully tested by @biljanaorescanin on 16/17 Oct 2023
GEOSldas tests passed except for "aggressive" tests, which failed the comparison with roundoff differences, as expected.